fix: clean up hedgehog controls on destroy - #45
Open
MattPua wants to merge 3 commits into
Open
Conversation
Generated-By: PostHog Desktop Task-Id: 8617733e-b663-4043-93e4-9512889a4153
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Generated-By: PostHog Desktop Task-Id: 8617733e-b663-4043-93e4-9512889a4153
MattPua
marked this pull request as ready for review
September 1, 2026 17:04
Generated-By: PostHog Desktop Task-Id: 8617733e-b663-4043-93e4-9512889a4153
MattPua
marked this pull request as draft
September 1, 2026 17:07
MattPua
marked this pull request as ready for review
September 1, 2026 17:08
MattPua
marked this pull request as draft
September 1, 2026 17:10
MattPua
marked this pull request as ready for review
September 1, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fkeypress can try to add a fireball to that destroyed renderer.Changes
0.0.55so consumers can take the fix without patching built artifacts.Testing
f, destroys controls, advances time, and confirms no more fireball calls occur.🤖 Agent context
posthog-desktopto separate the consumer app from the package fix.qa-teamto review teardown paths and fix the two actionable findings.writing-pr-descriptionsto revise this PR body.Created with PostHog Desktop