feat(perf): compare uncached and cached DuckDB - #1160
Open
bill-ph wants to merge 2 commits into
Open
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgwire_uncached(baseline),pgwire_cached, Trino, and Athena in the same frozen perf run. Both DuckDB variants use identical SQL, resources, and iteration counts. Trino and Athena run once each.pgwirebehavior. Version query/intent IDs asbalanced_v4to separate the new methodology from earlier history; no artifact schema changes or data migration.This replaces the initial broad worker-startup change. There are no production worker startup or configuration changes in the final diff. Explicit cache modes are used only by the perf harness.
Validation
just test-unitandjust test-perfpassed.git diff --checkpassed.just lintreports six pre-existing staticcheck findings in unchanged control-plane/main files.golangci-lint run --new-from-rev=origin/mainreports zero issues.Rollout
Run the frozen scenario from this PR branch to validate the four result sets before merging. No remote deployment or perf run has been triggered by this change. Local cache-mode runs must use a dedicated test warehouse because DuckDB cache settings are global within the worker; do not use a shared production worker.