feat(perf): compare frozen queries with Athena - #1154
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Athena on-demand as a third protocol in the frozen performance scenario so Duckgres raw Parquet, DuckLake via Duckgres/Trino, and Athena external-table latency are measured over the same immutable files.
The base infrastructure in PostHog/posthog-cloud-infra#10231 is applied. Merge and apply PostHog/posthog-cloud-infra#10273 before this PR: it publishes the Athena configuration to SSM and grants the existing CI role read access. No additional Athena GitHub secrets or variables are required.
Changes
query_results.csvv1 unchanged and addquery_service_metrics.csvfor queue, planning, engine, scanned-byte, DPU, and engine-version data/duckgres/perf/athenaafter AWS authentication and before deployment; validate all four fields before exporting any environment settingsTesting
just test-scenarioandjust test-perfpassbash -n scripts/scenario_athena_config.shpassesgolangci-lint run --new-from-rev=HEADbefore committing: zero new issuesjust lintwas run; it reports six pre-existing SA4023 findings inmain.go,cmd/duckgres-controlplane/main.go, andcontrolplane/control.go, outside this changeRollout
Merge and apply PostHog/posthog-cloud-infra#10273 first, then merge this PR and manually run
posthog_frozen_perf. The workflow reads the SSM configuration automatically; do not configure the former four Athena repository settings. Validate the first live Athena run against the other engines before relying on its comparisons.