fix(spaces): hold sidebar peek open while space Filter menu is open - #3972
fix(spaces): hold sidebar peek open while space Filter menu is open#3972dmarticus wants to merge 1 commit into
Conversation
The space sidebar's "Recent" Filter dropdown didn't hold the sidebar's hover-peek open while it was open, unlike every other sidebar-spawned menu (TasksHeader, ProjectSwitcher) which do via useHoldSidebarPeek(). When the sidebar is only hover-peeked (not pinned), moving the pointer toward the opened Filter menu let the panel collapse and stranded the dropdown's portal anchor, so filter conditions couldn't be picked. Wire the same peek-hold as the other menus. Generated-By: PostHog Code Task-Id: e2e30680-93e8-4ff2-8747-9f6a3bed2b68
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Hey @dmarticus, we've migrated this repo into the PostHog/posthog monorepo, so this PR needs to be recreated there. Easiest path: check out the monorepo and run the Shout if you get stuck. |
|
@charlesvien i actually think this PR is just no longer relevant – I'll kill it. |
2 participants
Problem
In the Spaces/Channels layout, the space sidebar's "Recent" list has a Filter control (Created by / Status). When the left sidebar is only hover-peeked (collapsed, not pinned), opening that Filter menu and moving the pointer toward it collapses the peeked panel and strands the dropdown's portal anchor — so you can't actually pick a filter condition. Reported from a Slack thread.
Changes
Wire
ChannelSidebar's FilterDropdownMenutouseHoldSidebarPeek()viaonOpenChange, holding the peek open while the menu is open. This matches the pattern already used by every other sidebar-spawned menu (TasksHeader,ProjectSwitcher) since the peek-hold fix landed; the space sidebar's filter dropdown was the one that missed it when the flag-gated Spaces layout was added.How did you test this?
pnpm --filter @posthog/ui typecheck— cleanbiome linton the changed file — cleanpnpm --filter @posthog/ui test— 2377 passed (incl.sidebarPeekStore/useHoldSidebarPeeksuites)Not manually verified in the running app.
Automatic notifications
Created with PostHog from a Slack thread