This repository was archived by the owner on Aug 6, 2026. It is now read-only.
feat(loops): add a default trigger to new loops - #3702
Merged
Merged
Conversation
Generated-By: PostHog Code Task-Id: 3206bbfa-c081-4ef7-84e7-e7f20ee878c1
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 3206bbfa-c081-4ef7-84e7-e7f20ee878c1
MattPua
marked this pull request as ready for review
July 22, 2026 13:25
Contributor
|
Reviews (1): Last reviewed commit: "fix(loops): default new triggers to week..." | Re-trigger Greptile |
There was a problem hiding this comment.
Small, contained UI/business-logic change to loop trigger defaults, outside risky territory, with test coverage and a positive Greptile bot reaction.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 25L, 2F substantive, 40L/3F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (40L, 3F, single-area, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0305ec2 · reviewed head f66822c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New loop forms start without a trigger, requiring an extra click before configuring when the loop runs.
Changes
How did you test this?
pnpm --filter @posthog/ui exec vitest run src/features/loops/loopFormTypes.test.tspnpm exec biome check packages/ui/src/features/loops/loopFormTypes.ts packages/ui/src/features/loops/loopFormTypes.test.ts packages/ui/src/features/loops/components/LoopTriggerEditor.tsxpnpm --filter @posthog/ui typecheckAutomatic notifications
Created with PostHog Code