This repository was archived by the owner on Aug 6, 2026. It is now read-only.
trunk-merge/pr-3614/647ca590-967f-404c-9726-f219a10b7875 - #3700
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
Port PostHog/code #3597 to mobile: the inbox Source filter and signal cards only handled ~9 native products, so signals from warehouse-backed sources (Stripe, Sentry, Zendesk, etc.) could not be filtered by source and rendered with a crude fallback label and no icon. - Derive the Source filter's warehouse entries from the shared EXTERNAL_INBOX_SOURCES registry instead of a hardcoded list. - Give warehouse sources a registry label and a generic Plug icon fallback in SignalCard (no per-source mobile icon assets, matching desktop's PlugIcon fallback). - Re-export the shared SourceProduct union from the mobile filter store so the wider set typechecks. - Move the pure sourceLine helper into the inbox utils and cover it, the widened source filter, and the derived options list with tests. Generated-By: PostHog Code Task-Id: 4fcd2e1a-e78a-4ca8-b939-fd728279884d
… inbox Add Intercom and HubSpot as inbox source toggles. Both are OAuth sources, but that needs no bespoke UI: the generic DynamicSourceSetup renders their connect form's oauth field, and the generic integration flow starter (separate PR) launches the OAuth flow by kind. So this is the same one-registry-entry change as any credential source — two entries in EXTERNAL_INBOX_SOURCES plus the SourceProduct/analytics unions and icons.
|
React Doctor found 1 issue in 1 file · 1 warning. 1 warning
Reviewed by React Doctor for commit |
trunk-io
Bot
deleted the
trunk-merge/pr-3614/647ca590-967f-404c-9726-f219a10b7875
branch
July 22, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA fb1d37c7fa5b9c01aa571ef1c2f55b75a82fec9b.
See more details about each PR in the batch here:
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing a batch with the changes from pull requests 3614 and 3690 - batching documentation.