This repository was archived by the owner on Aug 6, 2026. It is now read-only.
Archive tasks optimistically - #3584
Closed
MattPua wants to merge 2 commits into
Closed
Conversation
Remove archived tasks from the UI before host cleanup completes, while preserving rollback on failure and refreshing the authoritative archive record after success. Generated-By: PostHog Code Task-Id: ac916f1c-ce06-4167-b1bb-726a17a3fa02
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Restore the existing archive orchestration API and enable its optimistic mode explicitly for single-task archives. Generated-By: PostHog Code Task-Id: ac916f1c-ce06-4167-b1bb-726a17a3fa02
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Why: Single-task archives use the non-optimistic path, so the task stays visible until archive work finishes.
Changes
How did you test this?
pnpm --dir packages/core exec vitest run src/archive/archiveOrchestration.test.tspnpm turbo typecheck --filter=@posthog/uipnpm exec biome check packages/ui/src/features/archive/useArchiveTask.tsAutomatic notifications
Created with PostHog Code