Skip to content
This repository was archived by the owner on Aug 6, 2026. It is now read-only.

feat(ui): scope the breadcrumb row to task detail - #3560

Merged
adamleithp merged 1 commit into
mainfrom
posthog-code/hide-breadcrumb-row
Jul 18, 2026
Merged

feat(ui): scope the breadcrumb row to task detail#3560
adamleithp merged 1 commit into
mainfrom
posthog-code/hide-breadcrumb-row

Conversation

@adamleithp

@adamleithp adamleithp commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The in-pane breadcrumb/header row now renders only on the task-detail view. Every other page drops it — the title bar search carries wayfinding instead.

2026-07-18 00 33 07
  • ContentHeader returns null unless the active view is task-detail.
  • SkillsView and McpServersView no longer push header content, so their mirrored appearance in the Channels space loses the row too.
  • The /website Channels space keeps its own header (WebsiteLayout) and is unaffected.

Remaining mirrored pages (Home, Command Center) still push headers — out of scope here.

Test

  • Task detail → row intact (title + task actions).
  • Channel (/website/…) → own header intact.
  • Inbox / agents / new-task / home / Skills / MCP servers → no breadcrumb row.

🤖 Generated with Claude Code

@trunk-io

trunk-io Bot commented Jul 17, 2026

Copy link
Copy Markdown

😎 Merged manually by @adamleithp - details.

The in-pane breadcrumb/header row now renders only on the task-detail
view. Every other page drops it (the title bar search carries wayfinding
instead); the /website Channels space keeps its own header via
WebsiteLayout and is unaffected.

Also stop the Skills and MCP servers pages from pushing header content,
so their mirrored appearance in the Channels space loses the row too.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K18PGBxVQy1fnC9ADbst3y
@adamleithp
adamleithp force-pushed the posthog-code/hide-breadcrumb-row branch from 22d9076 to 0f9dd34 Compare July 17, 2026 23:33
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 0f9dd34.

@adamleithp adamleithp added Stamphog This will request an autostamp by stamphog on small changes trunk-merge-queue-submit Adding this label to a pull request enqueues it, and removing this label dequeues it labels Jul 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure UI scoping change: removes header breadcrumb from non-task-detail views by adding an early return in ContentHeader and cleaning up the now-dead useSetHeaderContent calls in two views. No logic, data model, or API surface touched.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(ui): scope the breadcrumb row to ta..." | Re-trigger Greptile

@adamleithp

Copy link
Copy Markdown
Contributor Author

/trunk merge

@adamleithp
adamleithp enabled auto-merge (squash) July 17, 2026 23:34
@adamleithp

Copy link
Copy Markdown
Contributor Author

/trunk merge

@adamleithp
adamleithp merged commit ea149be into main Jul 18, 2026
40 of 43 checks passed
@adamleithp
adamleithp deleted the posthog-code/hide-breadcrumb-row branch July 18, 2026 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Stamphog This will request an autostamp by stamphog on small changes trunk-merge-queue-submit Adding this label to a pull request enqueues it, and removing this label dequeues it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant