This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix(permissions): cap permission prompt height and scroll long content - #3417
Merged
Conversation
A very long permission request (e.g. a large shell command or MCP tool input) could grow the approval card taller than the viewport, pushing the Allow/Deny buttons off-screen with no way to scroll to them. Cap the ActionSelector card at 80vh and make the pending-action/question region scroll internally, keeping the action buttons pinned and always reachable. Generated-By: PostHog Code Task-Id: 2f1e1451-9626-40b3-80b7-478fe8a43dc8
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
added
the
Stamphog
tatoalo
marked this pull request as ready for review
July 14, 2026 10:42
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (1): Last reviewed commit: "fix(permissions): cap permission prompt ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a permission request is very long (e.g. a large shell command or a big MCP tool input, common with the codex adapter on worktree/local tasks), the approval card could grow taller than the visible area and push the Allow/Deny buttons off-screen. Because the card itself didn't scroll, users had no way to reach the buttons short of zooming the whole app out.
Changes
Cap the shared
ActionSelectorpermission card at80vhand make the pending-action + question region scroll internally (min-h-0 flex-1 overflow-y-auto), while the option rows and Allow/Deny buttons stay pinned and always visible. Fixing it in the shared primitive covers every permission kind and both the session view and the canvas permission dialog.How did you test this?
pnpm build(all packages)pnpm --filter @posthog/ui typecheck— cleanAutomatic notifications
Created with PostHog from a Slack thread