This repository was archived by the owner on Aug 6, 2026. It is now read-only.
Repository navigation
fix(code): Restore named leading-* utilities to fix oversized badges - #2139
Merged
Merged
Conversation
`isOnline` is already pulled from `useConnectivity()` earlier in the same component (line 136 in current HEAD), so the second destructure was a TS2451 redeclaration error that broke `pnpm typecheck`. Generated-By: PostHog Code Task-Id: 65a3c8df-1230-49a9-b67d-f530f154e8f4
`radix-themes-tw` overrides Tailwind's `lineHeight` scale to a numeric `1…9` mapping (one entry per Radix line-height token). Because that replaces rather than extends the default scale, named utilities like `leading-tight`, `leading-snug`, `leading-normal`, `leading-relaxed`, `leading-loose` silently stop compiling — Tailwind v4 doesn't emit the rule, so the className becomes a no-op. Most visible fallout: `Badge` uses `!leading-tight` to clamp the badge's line-height to 1.25× the 9px text. Without that override applying, content inherited Radix's `--line-height-1` (overridden to 20px in globals.css), so every `[Alpha]`, `P1`, status, etc. tag rendered at ~26px instead of ~17px. Other parts of the app silently lost intended `leading-relaxed` / `leading-normal` styling too. Re-add the named tokens via `extend.lineHeight` so they merge with the Radix preset's numeric scale instead of being replaced. Generated-By: PostHog Code Task-Id: 65a3c8df-1230-49a9-b67d-f530f154e8f4
Twixes
changed the title
Twixes
marked this pull request as ready for review
May 13, 2026 21:34
Contributor
|
Reviews (1): Last reviewed commit: "fix(code): restore named leading-* utili..." | Re-trigger Greptile |
adamleithp
approved these changes
May 13, 2026
adamleithp
left a comment
adamleithp
left a comment
Contributor
There was a problem hiding this comment.
I think this happened because of Quill, and were competing for tailwind defaults. I'll approve, but I don't think this is the answer, we should move away from these badges and use quill (and modify quill for these variants you want)
charlescook-ph
pushed a commit
that referenced
this pull request
May 14, 2026
MattBro
pushed a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tag badges (
[Alpha],P1, etc.) ballooned from ~17px to ~26px tall.Why
radix-themes-tw's preset replaces (not extends) Tailwind'slineHeightscale, soleading-tight/leading-snug/leading-normal/leading-relaxed/leading-loosesilently stopped compiling.Badge's!leading-tightoverride became a no-op, and Radix's--line-height-1(overridden to 20px inglobals.css) took over.Fix
Re-add the named tokens via
theme.extend.lineHeightso they merge with the Radix scale instead of replacing it.Also: one-line
SessionViewcleanup to unblockpnpm typecheck(TS2451 onmainfrom #1971).Created with PostHog Code