This repository was archived by the owner on Aug 6, 2026. It is now read-only.
Repository navigation
fix(sidebar): show created task immediately - #1908
Merged
jonathanlab merged 1 commit intoApr 29, 2026
Merged
Conversation
Contributor
Author
This was referenced Apr 28, 2026
jonathanlab
marked this pull request as ready for review
April 28, 2026 15:48
Contributor
|
Reviews (1): Last reviewed commit: "fix(sidebar): show created task immediat..." | Re-trigger Greptile |
tatoalo
approved these changes
Apr 28, 2026
jonathanlab
force-pushed
the
04-28-fix_sidebar_show_created_task_immediately
branch
from
April 29, 2026 10:26
f004c1c to
fb0d5fe
Compare
Contributor
Author
Merge activity
|
The sidebar filter required workspaces[task.id] to be set, but in
worktree mode onTaskReady fires early with workspace=null so the task
detail pane navigates while the sidebar hides the task until workspace
creation completes. Include actively provisioning task ids in the
filter so the sidebar matches the detail pane.
Also fix invalidateTasks: setQueryData(taskKeys.list()) wrote to a key
with no filters that the sidebar query never reads from. Switch to
setQueriesData over taskKeys.lists() with a duplicate guard so the
optimistic insert lands in every active list query.
Closes #1820
Generated-By: PostHog Code
Task-Id: 053dcd37-ddc9-4c17-869f-d67c405d0c1f
jonathanlab
force-pushed
the
04-28-fix_sidebar_show_created_task_immediately
branch
from
April 29, 2026 11:06
fb0d5fe to
c904c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/PostHog/code/issues/1820