Repository navigation
Fix desktop shelf-label printing and report SKUs - #1413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shelf labels previously opened the system print dialog and started with a 2,000-label batch. Desktop users can now choose a dedicated printer and send exact-size A4 sheets or individual thermal labels directly, with a five-label default and a one-label test.
The shared preview/print design uses larger product names and prices, top-aligned roll content, and shows the 80 mm roll around the 72 mm thermal print area. Existing receipt modes (Exact, Fast and Windows driver) remain available and were physically confirmed on POS-80C. Brother output was confirmed for a full 24-label A4 sheet. The pending sales-report SKU correction is included.
Printer/layout preferences are local to each till; no business data or sync lane changes. Explicit printer selection is required and uncertain label jobs are not retried automatically. Thermal cutter/feed margins vary by hardware.
Validation: 126 focused tests passed, plus 49 focused develop checks. Local POS-80C and Brother prints confirmed by the operator. Windows-driver spooler monitoring reported a false negative despite physical output. Installer is for local testing, not an automatic release.
Cart price correction: authenticated counter price overrides now reach checkout, including signed manager approval from the line editor. Sale-only edits preserve the catalogue price and existing channel validation. Local verification: 365 API tests, two frontend tests, ESLint zero errors. Existing branch-scoped sales sync carries the price snapshot; live reconnect verification remains pending. See docs/sale-only-price-edit.md.