Fix record saves and compact the Units dialog

[sridharkalaibala]

Branch and Add User saves could stop without a useful explanation. Branch Save rejected valid plus-address emails in a duplicate validator and left every tab expanded. Add User checked permissions only after profile validation passed, hiding missing-access feedback when another field was invalid; a selected branch without logo metadata could also throw before the users request.

Use complete form validation across tabs and Select2 fields, restore the tab layout after Save, and expose errors in the appropriate tab. Add User now shows profile and permission errors together beside the actions, explains password mismatches clearly, and safely handles missing branch-logo metadata. Tests exercise the real form validator through the users request, including Accountant role selection.

Branch editing waits for reference options instead of a 600 ms guess, restores saved state immediately, ignores obsolete branch responses, loads UPI fields, and resets the branch actually being edited. The reported live branch has no persisted phone/state; these changes allow saving the user's supplied values without inventing defaults.

Validation: all 8 repository checks passed for the branch fix (4,329 desktop tests passed, 5 skipped). The additional user changes pass dedicated submit-to-request regression tests, frontend build, and attribution checks; the full desktop suite passed 4,333 tests with 5 skipped. No API/schema changes.

Sync: the existing setting/updateGeneralSetting and users endpoints write the same branch/user IDs and fields. Existing tenant-global branches/users sync lanes remain unchanged; no migration, new collections, credentials, jobs, or Gateway/agent rollout. Physical till reconnect propagation was not exercised for these frontend-only fixes.

The Units dialog explicitly fits its contents instead of inheriting full drawer height. Electron render checks in light/dark desktop and dark mobile measured 17 px below the buttons, with no horizontal overflow. Frontend build and attribution check passed. This CSS-only change has no persistence or sync impact.

[github-actions]

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.