Skip to content

Handle long recovery paths and native uninstall process checks - #1393

Merged
sridharkalaibala merged 1 commit into
developfrom
fix/uninstall-recovery-long-path-develop
Oct 16, 2026
Merged

sridharkalaibala merged 1 commit into
developfrom
fix/uninstall-recovery-long-path-develop

Conversation

@sridharkalaibala

@sridharkalaibala sridharkalaibala commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The real Windows uninstall stopped while copying a long generated runtime filename into its recovery folder. Reproduce that failure and use extended Windows paths for enumeration, copying, hashing, and removal. Recovery remains verified before business data is deleted, and linked directories are refused. Read-only files are supported.

NSIS now runs the data helper with native 64-bit PowerShell on 64-bit Windows. The 32-bit host cannot reliably inspect 64-bit application paths; the helper refuses that host instead of skipping its running-app guard. Normal uninstall runs this guard even when all three Keep options are checked.

Validation: 12 focused Windows/NSIS/wording tests passed, covering all eight Keep combinations, active apps with keep/delete choices, unsafe 32-bit host, recovery failure, long read-only paths, linked directories, and registry cleanup. Attribution and diff checks passed. Both installer editions built successfully and passed package verification. GSHCL was installed through the native UI; its Windows registration is present and its installed helper matches the tested source.

This changes local installation/recovery files only; no cloud data or synchronization protocol changes. Full interactive uninstall of the final rebuilt installers remains to be verified.

@sridharkalaibala
sridharkalaibala merged commit 8ac91c0 into develop Oct 16, 2026
18 of 19 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant