Repository navigation
Handle long recovery paths and native uninstall process checks - #1392
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real Windows uninstall stopped while copying a long generated runtime filename into its recovery folder. Reproduce that failure and use extended Windows paths for enumeration, copying, hashing, and removal. Recovery remains verified before business data is deleted, and linked directories are refused. Read-only files are supported.
NSIS now runs the data helper with native 64-bit PowerShell on 64-bit Windows. The 32-bit host cannot reliably inspect 64-bit application paths; the helper refuses that host instead of skipping its running-app guard. Normal uninstall runs this guard even when all three Keep options are checked.
Validation: 12 focused Windows/NSIS/wording tests passed, covering all eight Keep combinations, active apps with keep/delete choices, unsafe 32-bit host, recovery failure, long read-only paths, linked directories, and registry cleanup. Attribution and diff checks passed. Both installer editions built successfully and passed package verification. GSHCL was installed through the native UI; its Windows registration is present and its installed helper matches the tested source.
This changes local installation/recovery files only; no cloud data or synchronization protocol changes. Full interactive uninstall of the final rebuilt installers remains to be verified.