Repository navigation
Verify Windows registration cleanup after uninstall - #1391
Merged
sridharkalaibala merged 2 commits intoOct 16, 2026
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GSHCL uninstall removed its application folder but left Windows uninstall and startup entries behind. Add a final cleanup section that uses the explicit per-user registry hive and the build's registry view, then checks removal before allowing the success page. It refuses to unregister a live application or metadata pointing to another installation.
The keep-data choices are unchanged. This is local Windows installation metadata; it does not change cloud data or synchronization.
Validation: 17 setup/recovery/Windows tests passed, including all eight keep combinations, recovery failure protection, and a compiled NSIS fixture covering stale, absent, live, and unrelated registrations with a changed shell context. Five uninstall wording tests and attribution checks passed. Both GSHCL and standard Posnic installers rebuilt successfully and passed package verification. A complete interactive uninstall of the rebuilt package remains to be verified: desktop automation blocked launching the uninstaller. The precise cause of the original interrupted cleanup is not established.