Skip to content

Fix record editor sizing, validation and shared customer phones - #1381

Merged
sridharkalaibala merged 4 commits into
developfrom
fix/record-form-polish
Oct 16, 2026
Merged

sridharkalaibala merged 4 commits into
developfrom
fix/record-form-polish

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

Record editors were retaining drawer height and leaving large blank areas below their forms. This update sizes dialogs to content, uses compact widths for small editors and units, fills the branch edit content area, and presents Staff account / API integration choices together. Legacy normal role labels now read Staff.

Valid plus-address emails are accepted. Customers can explicitly opt into sharing a phone number; duplicate prevention remains the default. Turning sharing off checks other records, including when the phone itself is unchanged. Shop location defaults and required phone/state validation remain intact.

Validation: frontend asset build, record-template DOM tests covering preserved controls/save handlers and small forms, email validation regression, customer controller/model/repository/service tests, light/dark and mobile rendered previews. Full local check and API regression results are recorded below after completion. Also repaired stale cloud-startup/controller test fixtures, existing migration formatting, and missing translation tags/values exposed by the full check.

Sync: customers.allow_shared_phone travels in the existing branch-scoped customer document and batch lane. POS/Gateway/agent manifests and document transfer helpers were checked; no transport changes are required. Existing identity, scope, timestamp/conflict and tombstone behavior remains unchanged. Live target has no unique phone index. Ship frontend and API together; desktop offline support requires the updated bundled API. Live multi-device reconnect/delivery and a new desktop installer were not verified/published.

Completed validation: npm run check passed all 8 checks (4,306 tests passed, 5 skipped); full API suite passed 12,887 tests (13 skipped); latest frontend build and attribution check passed. Eight actual-template form/validation tests passed, including the additional small editor templates. Light/dark, mobile, branch and compact customer-category previews were inspected. No existing printer paths were changed.

@sridharkalaibala
sridharkalaibala merged commit 7c80486 into develop Oct 16, 2026
23 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant