Repository navigation
Fix record editor sizing, validation and shared customer phones - #1381
Merged
Merged
Conversation
Save typed customers with sales and support GST place of supply
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record editors were retaining drawer height and leaving large blank areas below their forms. This update sizes dialogs to content, uses compact widths for small editors and units, fills the branch edit content area, and presents Staff account / API integration choices together. Legacy normal role labels now read Staff.
Valid plus-address emails are accepted. Customers can explicitly opt into sharing a phone number; duplicate prevention remains the default. Turning sharing off checks other records, including when the phone itself is unchanged. Shop location defaults and required phone/state validation remain intact.
Validation: frontend asset build, record-template DOM tests covering preserved controls/save handlers and small forms, email validation regression, customer controller/model/repository/service tests, light/dark and mobile rendered previews. Full local check and API regression results are recorded below after completion. Also repaired stale cloud-startup/controller test fixtures, existing migration formatting, and missing translation tags/values exposed by the full check.
Sync: customers.allow_shared_phone travels in the existing branch-scoped customer document and batch lane. POS/Gateway/agent manifests and document transfer helpers were checked; no transport changes are required. Existing identity, scope, timestamp/conflict and tombstone behavior remains unchanged. Live target has no unique phone index. Ship frontend and API together; desktop offline support requires the updated bundled API. Live multi-device reconnect/delivery and a new desktop installer were not verified/published.
Completed validation: npm run check passed all 8 checks (4,306 tests passed, 5 skipped); full API suite passed 12,887 tests (13 skipped); latest frontend build and attribution check passed. Eight actual-template form/validation tests passed, including the additional small editor templates. Light/dark, mobile, branch and compact customer-category previews were inspected. No existing printer paths were changed.