Skip to content

feat(rfq): reintroduce confirmed trade broadcasts#110

Closed
cesarenaldi wants to merge 2 commits into
mainfrom
feat/rfq-trade-broadcast-ready
Closed

feat(rfq): reintroduce confirmed trade broadcasts#110
cesarenaldi wants to merge 2 commits into
mainfrom
feat/rfq-trade-broadcast-ready

Conversation

@cesarenaldi

@cesarenaldi cesarenaldi commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • parse public RFQ_TRADE websocket frames as typed RfqTradeEvent session events
  • align the public event with the gateway contract: requester_id replaces requestor_public_id
  • omit settlement tx_hash from the public trade event; it remains available only in private RFQ_EXECUTION_UPDATE messages to the participating maker

Rollout

Verification

  • ruff format --check .
  • ruff check .
  • strict Pyright over the changed RFQ files
  • direct RFQ_TRADE parser smoke check
  • the websocket integration test requires local POLYMARKET_PRIVATE_KEY credentials and remains covered by CI

Base automatically changed from revert/rfq-trade-broadcast to main June 17, 2026 11:11
@shazam8253 shazam8253 force-pushed the feat/rfq-trade-broadcast-ready branch from 7dbdcbc to 17c0374 Compare June 18, 2026 04:39
@shazam8253

Copy link
Copy Markdown
Contributor

Superseded by #112, which implements the same SDK support directly from main without depending on the reverted feature branch.

@shazam8253 shazam8253 closed this Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants