Conversation
Please enter the commit message for your changes. Lines starting
nishaq503
left a comment
nishaq503
left a comment
There was a problem hiding this comment.
For the analysis tool, it seems that the Python wrapper is unnecessary. It could be done simply as a short bash script. That said, I don't think this should stop the branch from being merged.
There was a problem hiding this comment.
I assume that this file is identical to that provided by the client, except for the couple of line changes that you mentioned in Slack.
There was a problem hiding this comment.
Do the R requirements need to be installed in this specific order or can these six files be consolidated somehow?
There was a problem hiding this comment.
This Python wrapper seems completely unnecessary. It all boils down to calling the underlying R code via a subprocess call which is identical to running it from the command-line. The python code could all be replaced with a simple shell script, or the commands could just be baked into the Dockerfile.
|
closed in favor of #20 |
2 participants
add 2 new tools: