Clean up unused effectChance on Triple Arrows#276
Open
Zodiarche wants to merge 1 commit intoPokemonWorkshop:gen-packsfrom
Open
Clean up unused effectChance on Triple Arrows#276Zodiarche wants to merge 1 commit intoPokemonWorkshop:gen-packsfrom
Zodiarche wants to merge 1 commit intoPokemonWorkshop:gen-packsfrom
Conversation
Triple Arrows now uses a dedicated battle engine class with independent status/stats rolls, making effectChance unused. Set to 0 for consistency with isEffectChance: false. Related: pokemonsdk/pokemonsdk!1795
Aelysya
approved these changes
Apr 5, 2026
Collaborator
|
J'attends que la MR soit passée sur PSDK pour merge 👌 |
Author
Pas de soucis, merci ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectChanceto0on Triple Arrows in both Gen 9 packs (scarlet-violet and Legends Z-A)isEffectChance: falsewas already set — this aligns the value for consistencyRelated