chore: add section manager lambda key id to config #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetto
requested review from
katerinachinnappan and
kschelonka
and removed request for
a team
jpetto
force-pushed
the
SHIPIT-0214-add-section-manager-lambda-keyid
branch
from
7ced41e to
f679a3e
Compare
- should be no terraform changes! - see also Pocket/content-monorepo#253
mmiermans
approved these changes
Feb 14, 2025
| // COGNITO_JWT_ISSUER is not set in this repo (or anywhere?) | ||
| process.env.COGNITO_JWT_ISSUER || | ||
| 'cognito-idp.us-east-1.amazonaws.com/us-east-1_1alKls4qw', | ||
| // COGNITO_KIDS is not set in this repo (or anywhere?) |
Contributor
There was a problem hiding this comment.
Maybe the env is meant to override it for local development or testing? (Just a guess.)
Collaborator
Author
There was a problem hiding this comment.
best guess here is premature optimization. there were probably talks of creating env vars but it never happened.
src/config.ts
Outdated
| process.env.NODE_ENV === 'production' | ||
| ? ['CURMIG', 'CORPSL'] | ||
| ? ['CURMIG', 'CORPSL', 'SEMGRL'] | ||
| : ['CMGDEV', 'CORDEV'], |
Contributor
There was a problem hiding this comment.
Do we not need authentication in our Pocket-Dev environment? If we do, please generate separate credentials, because Pocket-Dev is used as a sandbox and not a secure place for production secrets.
Collaborator
Author
There was a problem hiding this comment.
added a dev key in a new commit!
- clean up a buggy spec test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
add section manager lambda key id to config.
also removing dependency on terraform cloud (SRE initiative, see Pocket/content-monorepo#253).