Skip to content

Fix NES size patch #2

Description

@greyrogue

I noticed the problem with the size calculation in nes_rom_extract.py. It should be app1.seek(romoffset+4) before the size calculation (missing +4). Otherwise you're reading the 'NES' string instead of the number of PRG and CHR banks. Also, I don't think any of the official ROMs will have the title footer, but I could be wrong. If they don't, the + 128 can be removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions