Repository navigation
👷 ci: allow the MIT-0 cffi licence in dependency-review - #550
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cffi 2.1.1 relicensed to MIT-0, which is more permissive than the allowed MIT. It is a cairosvg dependency of the docs-site build and never ships. Scoped to the package like the other exceptions.
konih
force-pushed
the
ci/cffi-mit0-licence
branch
from
November 13, 2026 10:54
6134c48 to
8167917
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: #544 (pip-compile refresh) fails
dependency-reviewon licence only: cffi 2.1.1 relicensed from MIT to MIT-0. MIT-0 is MIT without the attribution clause, so it is more permissive than a licence we already allow.This adds
pkg:pypi/cffias a package-scopedallow-dependencies-licensesexception with a reason comment. That follows the existing convention (cairosvg, certifi, #521): cffi is a cairosvg dependency of the docs-site build and never ships.Testing:
hack/test/ci_workflow_security_test.shpasses, both plain and with--self-test. After this merges, re-running #544 should turndependency-reviewgreen.