Metadata params checks and undefined object checks changes#54
Merged
Metadata params checks and undefined object checks changes#54
Conversation
Slashek
reviewed
Mar 30, 2026
| }); | ||
|
|
||
| it('should handle hash_assign as definition', () => { | ||
| const source = `{% hash_assign h['key'] = 'val' %}{{ h }}`; |
Contributor
There was a problem hiding this comment.
This is not a valid code; this will throw an exception when you try to execute it
Contributor
Author
There was a problem hiding this comment.
Removed this test.
Slashek
reviewed
Mar 30, 2026
| `; | ||
| const result = extractUndefinedVariables(source); | ||
| expect(result).to.deep.equal(['name']); | ||
| }); |
Contributor
There was a problem hiding this comment.
we can also add a test for inline graphql aka {% graphql res %}...{% endgraphql %}, for background tag - both as a function and inline
Slashek
reviewed
Mar 30, 2026
| const file = ` | ||
| {% doc %} | ||
| @param {String} a - required param | ||
| @param {String} unused - required but not used in source |
Contributor
There was a problem hiding this comment.
In this scenario, should we have another check that would tell us that we defined unused parameter, but we never use it in the code?
Contributor
Author
There was a problem hiding this comment.
We do have the UnusedDocParam check - it does exactly that. I modified the metadata-params check to stop requiring unused params instead.
Slashek
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified checks to treat all undefined variables as parameters passed to partial except cases when there is a defined doc tag for all liquid files except pages.