Fix #54: remove dependency on SSH multiplexing and the auth socket no…

[MorphiX00]

Summary

This PR removes the dependency on SSH multiplexing and the SSH auth socket, which are not supported on Windows.

Changes

• Remove the SSH multiplexing dependency on Windows.
• Remove the dependency on the SSH auth socket on Windows.

Related to #54

[omar-polo]

Hello,

Thanks for the PR for this but... there was already #56 pending 😅. I'll take a closer look at this to compare to #56 later today though.

Thanks!

[MorphiX00]

Indeed, but apparently the issue is not handled in the same way. I think this PR could be a good quick fix since it requires relatively few changes to the existing code. Then, later on, you could consider integrating the native ssh_mode of the PR #56 .

It would also be interesting to compare the performance of the OpenSSH implementation with the native ssh_mode implementation.

Another advantage of the native ssh_mode is that it would not depend on the OpenSSH binary, making it potentially compatible with older versions of Windows without requiring OpenSSH to be installed.

[stspdotname]

I agree that removing use of the control socket for Windows platforms is a better quick fix.

The new sftp.go code works on other platforms, too. I have tested it on OpenBSD without issues.

I am not convinced that falling back on a different SSH implementation is better, since it gives us two different code paths for a critical component. And I would rather keep relying on OpenSSH than other implementations.

[glemmaPaul]

Looks good and agreed on the maintenance costs of these different code paths in #56 , merging this in!

I'll also try to find some times to remove out ssh_mode but keep the tests in as they are still useful.