Feature/liquid glass UI - #120
Conversation
Refactor FullPlayerContent.kt to improve structure and add liquidGlass modifier for visual effects.
|
Please review the code |
|
Fix bugs |
|
| Filename | Overview |
|---|---|
| app/src/main/java/com/lostf1sh/pixelplayeross/presentation/components/player/FullPlayerContent.kt | The refactor leaves the file truncated mid-expression and removes helper declarations still referenced by retained code, preventing compilation. |
| .github/workflows/build-apk.yml | The new APK workflow uses JDK 17 despite the repository's JDK 21 requirement. |
| app/src/main/java/com/lostf1sh/pixelplayeross/ui/theme/LiquidGlass.kt | The shared visual modifier works through layered gradients but unconditionally creates an infinite animation for every instance. |
| app/src/main/java/com/lostf1sh/pixelplayeross/presentation/components/GradientTopBar.kt | Top-bar controls adopt the liquid-glass treatment, creating five continuously animated instances. |
| app/src/main/java/com/lostf1sh/pixelplayeross/presentation/components/PlayerInternalNavigationBar.kt | The internal navigation row gains a translucent animated glass surface and a partially transparent selected indicator. |
Prompt To Fix All With AI
### Issue 1
app/src/main/java/com/lostf1sh/pixelplayeross/presentation/components/player/FullPlayerContent.kt:730
**Full player source is truncated**
Every app compilation reaches this file, which ends midway through the `tween` expression and leaves `AnimatedVisibility`, `Scaffold`, and `FullPlayerContent` unterminated. The retained code also references helper declarations removed by this diff without replacements, so the app module cannot compile.
### Issue 2
.github/workflows/build-apk.yml:16-21
**Workflow uses unsupported JDK**
On every push or manual invocation, this workflow runs Gradle under JDK 17 even though the repository requires JDK 21, causing the APK build to run with an unsupported toolchain and fail before producing its artifact.
```suggestion
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
java-version: '21'
distribution: 'temurin'
cache: gradle
```
### Issue 3
app/src/main/java/com/lostf1sh/pixelplayeross/ui/theme/LiquidGlass.kt:35-44
**Glass controls animate perpetually**
Each `liquidGlass` instance unconditionally starts an infinite transition, so the six persistent top-bar and navigation controls continuously animate and redraw layered gradients while idle, adding ongoing rendering and battery cost. Passing `animated = false` would not stop the transition because that flag is only checked after the animation is created.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "feat(ui): style top bar controls as liqu..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| } | ||
| } | ||
| } | ||
| exit = fadeOut(animationSpec = tween(220, easing = |
There was a problem hiding this comment.
Every app compilation reaches this file, which ends midway through the tween expression and leaves AnimatedVisibility, Scaffold, and FullPlayerContent unterminated. The retained code also references helper declarations removed by this diff without replacements, so the app module cannot compile.
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/java/com/lostf1sh/pixelplayeross/presentation/components/player/FullPlayerContent.kt
Line: 730
Comment:
**Full player source is truncated**
Every app compilation reaches this file, which ends midway through the `tween` expression and leaves `AnimatedVisibility`, `Scaffold`, and `FullPlayerContent` unterminated. The retained code also references helper declarations removed by this diff without replacements, so the app module cannot compile.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
| cache: gradle |
There was a problem hiding this comment.
On every push or manual invocation, this workflow runs Gradle under JDK 17 even though the repository requires JDK 21, causing the APK build to run with an unsupported toolchain and fail before producing its artifact.
| - name: Set up JDK 17 | |
| uses: actions/setup-java@v4 | |
| with: | |
| java-version: '17' | |
| distribution: 'temurin' | |
| cache: gradle | |
| - name: Set up JDK 21 | |
| uses: actions/setup-java@v4 | |
| with: | |
| java-version: '21' | |
| distribution: 'temurin' | |
| cache: gradle |
Context Used: CONTRIBUTING.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/build-apk.yml
Line: 16-21
Comment:
**Workflow uses unsupported JDK**
On every push or manual invocation, this workflow runs Gradle under JDK 17 even though the repository requires JDK 21, causing the APK build to run with an unsupported toolchain and fail before producing its artifact.
```suggestion
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
java-version: '21'
distribution: 'temurin'
cache: gradle
```
**Context Used:** CONTRIBUTING.md ([source](https://github.com/pixelplayerhq/pixelplayeross/blob/main/CONTRIBUTING.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| val transition = rememberInfiniteTransition(label = "liquidGlass") | ||
| val sheen by transition.animateFloat( | ||
| initialValue = -0.35f, | ||
| targetValue = 1.35f, | ||
| animationSpec = infiniteRepeatable( | ||
| animation = tween(4200), | ||
| repeatMode = RepeatMode.Restart | ||
| ), | ||
| label = "glassSheen" | ||
| ) |
There was a problem hiding this comment.
Each liquidGlass instance unconditionally starts an infinite transition, so the six persistent top-bar and navigation controls continuously animate and redraw layered gradients while idle, adding ongoing rendering and battery cost. Passing animated = false would not stop the transition because that flag is only checked after the animation is created.
Context Used: CONTRIBUTING.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/java/com/lostf1sh/pixelplayeross/ui/theme/LiquidGlass.kt
Line: 35-44
Comment:
**Glass controls animate perpetually**
Each `liquidGlass` instance unconditionally starts an infinite transition, so the six persistent top-bar and navigation controls continuously animate and redraw layered gradients while idle, adding ongoing rendering and battery cost. Passing `animated = false` would not stop the transition because that flag is only checked after the animation is created.
**Context Used:** CONTRIBUTING.md ([source](https://github.com/pixelplayerhq/pixelplayeross/blob/main/CONTRIBUTING.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
I want this to try with liquid glassy effect