Fix post-v1 logic and security review findings - #23
Merged
Conversation
This was referenced Aug 1, 2026
Owner
Author
|
The non-blocking maintainability findings from this review have been separated into issue #25. That issue covers API/router decomposition, state-machine complexity, shared durable-delivery mechanics, lifecycle integration tests and operator UI structure. None of those refactors are required for this correctness/security PR and they should be delivered incrementally after this patch is stable in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A second independent post-v1 review found several issues that passed the original happy-path and production acceptance tests but matter under retries, delayed evidence, large retention backlogs, optional integrations and hostile redirects.
Correctness fixes
STATEMENT_TIMEZONE(Asia/Kolkataby default)Reliability/security fixes
Code cleanup
<progress>markup so strict CSP remains possibleVerification
go vetstaticcheckgovulncheck: no reachable vulnerabilitiesgo test -race -count=1 ./...