Skip to content

fix(scanRear): guard kill against missing or stale scan_pid #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilippMundhenk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(scanRear): guard kill against missing or stale scan_pid #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78de131
fix(scanRear): guard kill against missing or stale scan_pid
PhilippMundhenk May 17, 2026
05a1dbd
added new version of skey tool
PhilippMundhenk May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ apt-get -y --no-install-recommends install \
apt-get -y clean && \
rm -rf /var/lib/apt/lists/* && \
wget https://download.brother.com/welcome/dlf105200/brscan4-0.4.11-1.amd64.deb --progress=dot:giga -O /tmp/brscan4.deb && \
wget https://download.brother.com/welcome/dlf006652/brscan-skey-0.3.2-0.amd64.deb --progress=dot:giga -O /tmp/brscan-skey.deb && \
wget https://download.brother.com/welcome/dlf006652/brscan-skey-0.3.5-0.amd64.deb --progress=dot:giga -O /tmp/brscan-skey.deb && \
dpkg -i --force-all /tmp/brscan4.deb && \
dpkg -i --force-all /tmp/brscan-skey.deb && \
rm -f /tmp/brscan4.deb /tmp/brscan-skey.deb
Expand Down
9 changes: 7 additions & 2 deletions script/scanRear.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ output_pdf_file="/scans/${date}.pdf"

cd "$tmp_dir"

kill -9 "$(cat scan_pid)"
rm scan_pid
if [ -f scan_pid ]; then
pid=$(cat scan_pid)
if [ -n "$pid" ] && kill -0 "$pid" 2>/dev/null; then
kill -9 "$pid"
fi
rm -f scan_pid
fi

function scan_cmd() {
# `brother4:net1;dev0` device name gets passed to scanimage, which it refuses as an invalid device name for some reason.
Expand Down
Loading