Add Android support for name parameter, addressing issue #31#32
Open
guyc wants to merge 1 commit intoPhilippKrone:masterfrom
Open
Add Android support for name parameter, addressing issue #31#32guyc wants to merge 1 commit intoPhilippKrone:masterfrom
guyc wants to merge 1 commit intoPhilippKrone:masterfrom
Conversation
ShivamKJJW
approved these changes
Sep 23, 2016
ShivamKJJW
left a comment
ShivamKJJW
left a comment
There was a problem hiding this comment.
It is a valid change and require for file upload with a different file name.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #31 so that the name parameter behaves in Android the same as it does in the iOS implemenation, and also matches the documentation.
nameparameter is specified, send the value provided.nameis not specified, use the value of thefilenameparameter insteadPreviously a fixed value of
imageis always sent.