Skip to content

thank you and suggestions #2

Description

@abraidotti

Hey, Phil. Thanks for putting the files up with detailed instructions. Two years later, the lab works right out of the box!
I have a couple suggestions for the readme:

  • add a specific note about editing the aws.tf file for the profile and region if they don't use the defaults.
  • warn user that they may need to turn off microsoft defender to run the adlab.ps1 script
  • add "terraform init" between cd terraform and terraform apply
  • typo in ssm param on line 361 in aws.tf --> "unconstrainer-user" should be "unconstrained-user"

I could otherwise send a PR. Thanks again!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions