Skip to content

Fix crash now .write has become .save#205

Open
thomaswilliamsastro wants to merge 1 commit into
mainfrom
fix-model-write
Open

Fix crash now .write has become .save#205
thomaswilliamsastro wants to merge 1 commit into
mainfrom
fix-model-write

Conversation

@thomaswilliamsastro

@thomaswilliamsastro thomaswilliamsastro commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator
  • Fix crash now .write has become .save

@thomaswilliamsastro
Fix crash now .write has become .save
a45dd7d 
- Fix crash now .write has become .save
@thomaswilliamsastro

thomaswilliamsastro commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

@akleroy this fixes a crash in astrometric_align with the latest JWST version. I don't think you caught this in testing since we weren't running end-to-end, but can we get this merged urgently?

@low-sky

low-sky commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Is back compatibility a concern? (i.e., was the .save method around for a few versions?)

@thomaswilliamsastro

thomaswilliamsastro commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

@low-sky I think it changed with JWST v2, but we pin to specific versions so no back compat issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akleroy akleroy Awaiting requested review from akleroy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaswilliamsastro @low-sky