Skip to content

BUGFIX: cleanmask support for sdintimaging#360

Merged
thomaswilliamsastro merged 1 commit into
PhangsTeam:masterfrom
low-sky:master
Jun 23, 2026
Merged

BUGFIX: cleanmask support for sdintimaging#360
thomaswilliamsastro merged 1 commit into
PhangsTeam:masterfrom
low-sky:master

Conversation

@low-sky

@low-sky low-sky commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

The new sdintimaging code crashes out when a cleanmask is used. It tries to use the joint cube as a header template for aligning the clean mask. That cube doesn't exist at the time when the alignment code is called. This bug fix uses the regridded single dish cube as a header template instead.

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.27%. Comparing base (e4693b8) to head (a53d33b).

Files with missing lines Patch % Lines
phangsPipeline/handlerImaging.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #360      +/-   ##
=========================================
- Coverage    6.27%   6.27%   -0.01%     
=========================================
  Files          38      38              
  Lines       15238   15242       +4     
  Branches     3662    3664       +2     
=========================================
  Hits          956     956              
- Misses      14268   14272       +4     
  Partials       14      14              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator

This seems reasonable to me. Just to check, the .int file also doesn't exist at this point? If that does, I'd suggest using that over the .sd, just for readability

@low-sky

low-sky commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

It didn't actually exist at this point but agree that int would be best to template off.

@thomaswilliamsastro thomaswilliamsastro merged commit f87f077 into PhangsTeam:master Jun 23, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants