BUGFIX: cleanmask support for sdintimaging#360
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=========================================
- Coverage 6.27% 6.27% -0.01%
=========================================
Files 38 38
Lines 15238 15242 +4
Branches 3662 3664 +2
=========================================
Hits 956 956
- Misses 14268 14272 +4
Partials 14 14 ☔ View full report in Codecov by Harness. |
thomaswilliamsastro
approved these changes
Jun 23, 2026
Collaborator
|
This seems reasonable to me. Just to check, the .int file also doesn't exist at this point? If that does, I'd suggest using that over the .sd, just for readability |
42855af to
3aa8c22
Compare
Collaborator
Author
|
It didn't actually exist at this point but agree that int would be best to template off. |
Update CHANGELOG
3aa8c22 to
a53d33b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new sdintimaging code crashes out when a cleanmask is used. It tries to use the joint cube as a header template for aligning the clean mask. That cube doesn't exist at the time when the alignment code is called. This bug fix uses the regridded single dish cube as a header template instead.