overwrite_min_loops#359
Merged
Merged
Conversation
This PR adds a ``force_overwrite_min_loops`` parameter that means we don't necessarily need to do some minimum number of loops. Currently, this only applies if there's no model flux after the first iteration, or if there's no flux change between loops, but adds an option to extend this to other criteria
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=========================================
- Coverage 6.27% 6.27% -0.01%
=========================================
Files 38 38
Lines 15231 15238 +7
Branches 3660 3662 +2
=========================================
Hits 956 956
- Misses 14261 14268 +7
Partials 14 14 ☔ View full report in Codecov by Harness. |
low-sky
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
force_overwrite_min_loopsparameter that means we don't necessarily need to do some minimum number of loops. Currently, this only applies if there's no model flux after the first iteration, or if there's no flux change between loops, but adds an option to extend this to other criteria