Skip to content

overwrite_min_loops#359

Merged
thomaswilliamsastro merged 2 commits into
masterfrom
min-loop-logic
Jun 23, 2026
Merged

overwrite_min_loops#359
thomaswilliamsastro merged 2 commits into
masterfrom
min-loop-logic

Conversation

@thomaswilliamsastro

Copy link
Copy Markdown
Collaborator

This PR adds a force_overwrite_min_loops parameter that means we don't necessarily need to do some minimum number of loops. Currently, this only applies if there's no model flux after the first iteration, or if there's no flux change between loops, but adds an option to extend this to other criteria

This PR adds a ``force_overwrite_min_loops`` parameter that means we don't necessarily need to do some minimum number of loops. Currently, this only applies if there's no model flux after the first iteration, or if there's no flux change between loops, but adds an option to extend this to other criteria
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.27%. Comparing base (67daf60) to head (a790467).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
phangsPipeline/casaImagingRoutines.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #359      +/-   ##
=========================================
- Coverage    6.27%   6.27%   -0.01%     
=========================================
  Files          38      38              
  Lines       15231   15238       +7     
  Branches     3660    3662       +2     
=========================================
  Hits          956     956              
- Misses      14261   14268       +7     
  Partials       14      14              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@thomaswilliamsastro thomaswilliamsastro merged commit e4693b8 into master Jun 23, 2026
8 of 10 checks passed
@thomaswilliamsastro thomaswilliamsastro deleted the min-loop-logic branch June 23, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants