[PER-10762] Give each inline value editor its own field id and turn off autofill - #1180
Open
aasandei-vsp wants to merge 1 commit into
Open
aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
The Name field in the info panel and the record view rendered as a bare <input name="text"> with no id and no autocomplete attribute, and every other editable metadata field rendered with that same generic name. Because of that, the browser could not differentiate between text inputs, so it would give the same suggestions to all of them. Now each instance of the inline value edit is uniquely identified, so there won't be any more suggestions appearing. Issue: PER-10762
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 53.12% 53.13%
=======================================
Files 364 364
Lines 12776 12778 +2
Branches 2323 2323
=======================================
+ Hits 6787 6789 +2
+ Misses 5754 5751 -3
- Partials 235 238 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The only remaining finding is a non-blocking test-coverage nit.
Review effort: Lite
Findings: None
What changed in this PR
Updates inline value editors to prevent browser autofill/history suggestions from carrying values between fields.
Changes:
- Generates unique control IDs and names per editor.
- Disables autocomplete for text, textarea, and select controls.
- Adds tests for the new attributes and behavior.
| File | Summary |
|---|---|
src/app/shared/components/inline-value-edit/inline-value-edit.component.ts |
Generates unique control identifiers. |
src/app/shared/components/inline-value-edit/inline-value-edit.component.spec.ts |
Tests autocomplete and identifier behavior. Nit: extend assertions to all control branches, including description-textarea. |
src/app/shared/components/inline-value-edit/inline-value-edit.component.html |
Applies unique IDs/names and disables autocomplete. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
slifty
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual test cases — no browser autofill on inline metadata fields
The saved-value dropdown is gone ⭐
(run this whole area in Chrome, Firefox and Safari — this is browser
behaviour, not app behaviour, and the three do not have to agree)
Scenario — establish the bug on production first
all, and type
zzz-history-probe. Press Enter.zzz-history-probe.z.zzz-history-probe— a value that was never typed into this field. This is thebug.
zzz-history-probe, and clicking away saves it.This is the reported symptom reproduced.
Scenario — the same sequence on this branch
z.zzz-history-probestill sitting in the browser's history from the steps above.A new nameand press Enter.A new nameexactly as typed.zagain.Scenario — nothing new accumulates either
probe-one,probe-twoand
probe-three, pressing Enter each time.probe.The settings pages ⭐
Scenario — Profile
it was never part of this change.
editing inline).
Scenario — Account Settings
Regression — the shared editor still behaves
Cheap sanity checks on the component that changed; these were traced as behaviourally
unchanged, so they are here to confirm rather than to discover.
record's details load.