[PER-10778] Video stuck in processing - #1179
Open
aasandei-vsp wants to merge 2 commits into
Open
aasandei-vsp wants to merge 2 commits into
aasandei-vsp wants to merge 2 commits into
Conversation
Stela leaves out records that it cannot return, so the list of records we asked for might not be what we receive. Changing the mapping to actually look for id won't mark an item that has been skipped as fully fetched. Issue: PER-10778 modified: src/app/shared/services/data/data.service.ts
… renderer Up until now, we would only read the record, in this case the video when the component was initialized. Now we read the record on every change. This means the "Video is processing" message would appear when the item was actually still not available, but then disappear when the data has finished processing. Issue: PER-10778
aasandei-vsp
changed the base branch from
main
to
PER-10680-migrate-navigate-lean-refresh-current-folder
September 19, 2026 13:05
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PER-10680-migrate-navigate-lean-refresh-current-folder #1179 +/- ##
==========================================================================================
+ Coverage 53.85% 54.02% +0.17%
==========================================================================================
Files 364 364
Lines 12765 12786 +21
Branches 2327 2332 +5
==========================================================================================
+ Hits 6874 6908 +34
+ Misses 5650 5638 -12
+ Partials 241 240 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual test cases — video stuck on "This video is processing"
Setup: Sign in as the owner of an archive and open a private folder holding
at least 12 items, of which at least 3 are videos that play normally today.
You need: one folder with more than 12 children so the viewer's prefetch window
matters, one video near the end of that folder's list, one record with a
distinctive name and size sitting directly next to a video, and one subfolder.
The visible change: a video that opens before its files have arrived no longer
sits on
This video is processing. Please check back later.until you leave theviewer — it starts playing on its own. Nothing about the placeholder's wording or
appearance changed.
Playing a video ⭐
Scenario — opening a video directly
video appears with working controls. No processing message at any point.
Scenario — arrowing onto a video
This is the case that was broken before: arrowing set the record and drew the player
in the same breath, so a video reached this way could show the placeholder and never
recover.
(or click the
›control) once.message appears at all it is momentary and clears on its own — you should
not have to press Back to make it go away.
The placeholder still appears when it should
Scenario — a record whose file really is not there yet
open it.
This video is processing.andPlease check back later.— and if it shows that, leave the viewer open.is the fix — previously it stayed until the viewer was closed and reopened.
Record details are the right record's ⭐
Scenario — arrowing between neighbours
and Type.
video's, and not a blank Size.
Size is never blank for a record that has a file.
Scenario — multi-select
one video.
Folders still load their own contents
Scenario — opening and leaving a subfolder
listed — not the parent's.
Download and tags
Scenario — downloading straight from the list
Scenario — the tag editor
Regression list
Cheap sanity checks; these were traced as unchanged by this PR.