[PER-10655] Add edtf formatted dates in the file list - #1175
Open
aasandei-vsp wants to merge 4 commits into
Open
aasandei-vsp wants to merge 4 commits into
aasandei-vsp wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## PER-10680-migrate-navigate-lean-refresh-current-folder #1175 +/- ##
==========================================================================================
+ Coverage 53.85% 54.16% +0.31%
==========================================================================================
Files 364 366 +2
Lines 12765 12926 +161
Branches 2327 2392 +65
==========================================================================================
+ Hits 6874 7001 +127
- Misses 5650 5674 +24
- Partials 241 251 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aasandei-vsp
force-pushed
the
PER-10680-migrate-navigate-lean-refresh-current-folder
branch
from
September 17, 2026 15:25
553df48 to
5e1322c
Compare
aasandei-vsp
force-pushed
the
PER-10655-EDTF-in-file-list
branch
from
September 17, 2026 15:39
4757231 to
dfb963c
Compare
aasandei-vsp
force-pushed
the
PER-10680-migrate-navigate-lean-refresh-current-folder
branch
from
September 18, 2026 09:37
5e1322c to
57f1dd3
Compare
…friendly text The EDTF date comes as a string from stela in the displayTime property. Its representation is very technical, so this service will do the heavy lifting of transforming any edtf date string into a readable text, for both the list and the sidebar, with the possibility of extension, in case we need to show the edtf date in other places, with specific formatting. Issue: PER-10655
…ted edtf date The edtf display component uses the edtf display service to format the edtf date that comes from stela on the displayTime property. It adds styling and behaviour so it fits correctly in the file list and also show more data when it is needed via a tooltip. Issue: PER-10655
Now the file list component shows the edtf date using the display edtf date component and dropped the prDate pipe, as it could not support the formatting of the edtf date and the newly added behaviour. The prDate pipe has not been removed, because it is used in other places for formatting plain dates and times (like the creation date or the upload date). Issue: PER-10655
When the user would input 1 for the month, this is considered January, which is correct. The display service would actually buffer that date to 1X, adding unspecified digits, which is incorrect. Issue: PER-10655
aasandei-vsp
force-pushed
the
PER-10655-EDTF-in-file-list
branch
from
September 18, 2026 09:42
9a0c880 to
600dd7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual test cases — EDTF dates in the file list
Setup: An archive you own, on a build with the
edtf-dateflag available.You need: one record with a year-only date (
1985), one with a year and monthonly, one with a full date, one with a full date and a time, one approximate,
one uncertain, one marked Unknown, one folder with a closed date range
inside one year, one folder with an open-ended range, and one record left with
no date at all. Create them through the date editor in the info sidebar where
you can; where the editor is not available yet, set
displayTimeby hand.Date column — single values ⭐
Scenario — precision is preserved
edtf-dateflag on and open Private Files on a desktop-widthwindow, so the Date column is visible.
1985.April 1985.Apr. 12, 1985.1440px.
Apr. 12, 1985 • 11:20 PM. No seconds,and no timezone beside it (this is follow-up work that needs all the EDTF date work to be merged)
Scenario — qualifiers and unknown
~, in lighter text than the date.?, in lighter text.%.Unknownin lighter text.Date column — ranges
Scenario — merging and open ends
Apr. 12 — Jun. 10, 1985.Sep. 24 — 30, 2001.Sep. 24, 2001 • 9:45 AM — 4:00 PM. This is the only range shape thatkeeps its times, and the only one wide enough to truncate at 12rem.
Afterfollowed by the known date, withAfterinlighter text.
Beforefollowed by that date.Unknown — Unknown.Scenario — wrapping instead of truncating ⭐
different years and carries times, so it shows an info icon.
Sep. 15, 2026 — Dec. 21, 2027with the icon after it.Scenario — the info icon and the tooltip ⭐
hiding its times, and the icon is what says so.
FromandTo, each showingthat side's full date and its time — the times the row does not show.
Unknown one, a range with no times at all, and the same-day range that
shows both its times.
only for a range whose times are not visible.
The sidebar and the list ⭐
(they share one renderer, but deliberately not one style)
1985.April 12, 1985(full month, zero-padded day), the list reads
Apr. 12, 1985.~without a reload.a reload.
Surfaces that are not the main file browser
/p/archive/…).With the flag off
edtf-dateoff, remove the edtf dates(only leave the "normal" dates) and reload the file list.— the legacy
YYYY-MM-DDon one line, the time with itsCDT/CSTsuffixunder it. If Edtf dates are still present, the column will show "Invalid date".
Regression sweep
Cheap checks; these paths were traced as unchanged but they share the row component.
before and after the reload.
sortChildItemsdivergence, not a new bug. (this will have a separate ticket, as it needs both BE and FE changes)format.
including part-typed values such as
198reading198X.