[PER-10673] Soften the focus ring on form controls - #1174
Open
aasandei-vsp wants to merge 1 commit into
Open
aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 53.79% 53.86% +0.07%
==========================================
Files 359 359
Lines 12384 12384
Branches 2256 2256
==========================================
+ Hits 6662 6671 +9
+ Misses 5485 5477 -8
+ Partials 237 236 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Since we upgrated to Bootstrap 5, the focus ring on inputs became a solid block instead of being a soft shadow. In order to revert this change, the best solution is to override the bootstrap 5 variables that provide that shadow effect, instead of just adding a blur to the input itelf. Issue: PER-10673
aasandei-vsp
force-pushed
the
PER-10673-fix-bootstrap-input-shadow
branch
from
September 18, 2026 09:47
d7ba403 to
6d66ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual test cases — softer focus ring on form controls
Setup: Any account with an archive you can edit. No feature flags. You need: one archive whose Archive profile has a person type, one folder or record with editable metadata, and a browser you can tab around in. Run this on a build of
PER-10673-fix-bootstrap-input-shadow.Focusing any text field, dropdown or checkbox now draws a soft fading halo instead of a flat grey rectangle. Nothing moves, resizes or changes colour otherwise.
Archive profile and person information ⭐
(the surface the bug was reported on — the fields here show no border until focused, which is why it looked worst)
Scenario — the reported field
Scenario — a dropdown beside a text field
Every other form in the app
(spot checks — the change is global, so pick surfaces you already have data in)
Scenario — sidebar and dialogs
Login, signup and onboarding ⭐
(these use a different input component and must be completely unchanged — if anything moves here, the fix has leaked past its intended scope)
Scenario — auth fields keep their own treatment
main.Regression sweep
Cheap sanity checks; these were traced as unchanged by this PR but are worth 30 seconds.