Add coordinate modal UX

[slifty]

This PR adds a new modal for picking locations via map pins / coordinates. Similar to the uncertain location UX we recently added this is JUST about the user experience and the resulting selections are not saved. It's also behind the feature flag since it is ultimately part of the new location feature.

This PR also includes some componentization improvements which impact the locations modal we just added.

Resolves #1159

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.64%. Comparing base (217c054) to head (4712a13).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   53.12%   53.64%   +0.52%     
==========================================
  Files         364      368       +4     
  Lines       12776    12925     +149     
  Branches     2323     2363      +40     
==========================================
+ Hits         6787     6934     +147     
- Misses       5754     5756       +2     
  Partials      235      235              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

A few type contracts in the new utilities/component don’t match actual runtime/usage (optional/null inputs and optional view child), which should be corrected for clarity and future safety.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR introduces a new coordinate-picking modal (map pin + free-form coordinate text) and wires it into the file-browser sidebar UX behind the existing uncertain-locations feature flag, without persisting changes.

Changes:

• Added coordinate parsing/formatting utilities (with unit tests) for DMS + decimal-degree inputs.
• Updated the sidebar location section to split “coordinates” vs “place/address” actions when uncertain-locations is enabled, including map-preview click routing.
• Added a new standalone CoordinatePickerComponent modal (with tests) and exposed it via EditService.openCoordinateDialog.

File summaries

File	Description
src/app/shared/utilities/coordinates.ts	Adds coordinate format/parse helpers and LocnVOData → coordinates extraction.
src/app/shared/utilities/coordinates.spec.ts	Unit tests covering formatting and parsing behavior/edge cases.
src/app/file-browser/components/sidebar/sidebar.component.ts	Adds coordinate/address display logic and map preview routing behind feature flag.
src/app/file-browser/components/sidebar/sidebar.component.spec.ts	Extends sidebar tests for the new split location UX and dialog routing.
src/app/file-browser/components/sidebar/sidebar.component.scss	Adds styling for coordinate display and location buttons.
src/app/file-browser/components/sidebar/sidebar.component.html	Updates Location section UI to show separate coordinate/address actions when flagged.
src/app/file-browser/components/coordinate-picker/coordinate-picker.component.ts	Implements the new coordinate picker modal with map + text input synchronization.
src/app/file-browser/components/coordinate-picker/coordinate-picker.component.spec.ts	Tests modal initialization, map clicks, typing behavior, and save/cancel flows.
src/app/file-browser/components/coordinate-picker/coordinate-picker.component.scss	Styles the new modal layout and invalid-state presentation.
src/app/file-browser/components/coordinate-picker/coordinate-picker.component.html	Modal template including map, marker, coordinate input, and footer actions.
src/app/core/services/edit/edit.service.ts	Adds openCoordinateDialog to open the new coordinate picker modal.

Review details

Suppressed comments (1)

src/app/file-browser/components/coordinate-picker/coordinate-picker.component.ts:94

• @ViewChild(GoogleMap) is undefined until after view init and can also be absent in tests; the code already treats it as optional via this.map?.googleMap. Marking the field optional aligns the type with actual usage.

	@ViewChild(GoogleMap) map: GoogleMap;

• Files reviewed: 11/11 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

There are a few concrete correctness/contract issues (notably parseCoordinates typing vs usage and invalid styling being overridden on focus) that should be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

src/app/shared/utilities/coordinates.ts:109

• parseCoordinates is typed to accept only string, but it is implemented defensively (text ?? '') and the spec calls it with null. Updating the parameter type will make the contract consistent and avoid type errors in stricter TS settings.

export const parseCoordinates = (text: string): Coordinates | null => {

src/app/shared/components/icon-text-input/icon-text-input.component.scss:24

• When the field is both invalid and focused, the :focus-within rule sets the border back to blue, which hides the invalid state during editing. Add an override so invalid styling wins while focused.

	&:focus-within {
		@include input-focus-state;
		border-color: $PR-blue-100;

• Files reviewed: 27/27 changed files
• Comments generated: 1
• Review effort level: Lite

[aasandei-vsp]

This PR is quite big and there are certain commits that could have been their own PRs or be grouped in smaller PRs.

[slifty]

I'm going to break this PR into a few stacked pieces per your very legit point that 2k lines changed is no way to live or review.

I'll keep this PR open, but once the stacking is done it should have a much smaller footprint.

[slifty]

@aasandei-vsp I pulled a bunch into separate PRs; I know this is still a big PR but I do think that it's all one coherent change at this point. I can break it down more, but I'm hoping that it's reviewable since it's broken into the three separate commits

[Copilot]

🟡 Changes recommended

Runtime wiring, map initialization, validity propagation, and coordinate-sign handling issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

src/app/shared/utilities/coordinates.ts:91

• SIGNED_NUMBER accepts an explicit +, but the parsed Angle stores only the numeric value and this check only detects negative degrees. Therefore parseCoordinates('+38 S, 9 E') is accepted as -38 even though the explicit positive sign contradicts S, whereas the analogous negative-sign cases are rejected. Preserve whether a sign was supplied (or otherwise reject explicit + with S/W) and add a regression test.

const contradictsItsHemisphere = (angle: Angle): boolean =>
	angle.hemisphere !== null && angle.degrees < 0;

• Files reviewed: 10/11 changed files
• Comments generated: 3
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

Invalid stored coordinates can be passed to Google Maps, and ready-map coordinate entry remains at country-level zoom.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 10/11 changed files
• Comments generated: 2
• Review effort level: Lite

[aasandei-vsp]

Mostly small improvements, but I'd really like to make sure we emit an event when a location is updated and have some user friendly validation before merging this.
Also, not required for this PR, but when we start using the modal, I'd like to have some manual tests that I could also run myself, as an extra pair of eyes on the business specs never hurt :D

[Copilot]

🟡 Changes recommended

Later coordinate edits can be lost when entered before Google Maps finishes loading, leaving the map centered on stale coordinates.

Get a fresh assessment by requesting another Copilot review.

Review details

• Files reviewed: 12/13 changed files
• Comments generated: 1
• Review effort level: Lite

[aasandei-vsp]

LGTM