[PER-10679] Replace navigateLean with getWithChildren for the timeline view

[aasandei-vsp]

Warning

Do not merge before #1135 , this PR depends on the mappings from that specific PR
Depends on accessRole being on stela records and folders

Manual test cases — timeline view moved from navigateLean to getWithChildren

Note

The timeline folder tiles no longer show an N items count. That is expected — Stela's
folder payload has no record-count field. The tile renders without the count line rather
than showing zero.

---

Timeline navigation ⭐

Scenario — loading the timeline

1. Navigate to Public files, then switch to the timeline view.
   • EXPECTED: Items plot on the timeline and the breadcrumb bar shows the folder path.

Scenario — clicking a folder in the timeline

1. Click a folder tile on the timeline.
   • EXPECTED: The view navigates into that folder and its contents plot.
2. Check the breadcrumb bar.
   • EXPECTED: A new crumb is appended for the folder you entered.

Scenario — clicking a breadcrumb

1. Navigate two folders deep, then click the first folder crumb in the bar.
   • EXPECTED: The timeline actually navigates back to that folder and its contents
     change. It does not just zoom or refit in place.

Scenario — deep link

1. Copy a timeline URL of the form /app/private/view/timeline/{archiveNbr}/{folderLinkId}
   and open it in a fresh tab.
   • EXPECTED: The folder loads and plots. Previously this path could not resolve at all.

---

Permissions ⭐

(run as both the owner and the Viewer account — the point is that the two differ)

Stela reports the caller's role as owner / viewer, which this PR translates into
access.role.owner / access.role.viewer. Untranslated, every gate denied.

Scenario — owner keeps their actions

1. Go to the private list view
2. Click on a row(record or folder)
   • EXPECTED: Rename, Copy and Delete are all enabled.

Scenario — viewer is still restricted

1. Open a folder shared to you as a Viewer.
2. Click a row (record or folder)
   • EXPECTED: Write actions (Rename, Delete) are disabled.

---

Breadcrumbs outside the timeline

Scenario — unlisted share breadcrumbs

1. Open an unlisted share link to a nested folder.
   • EXPECTED: The breadcrumb bar renders the full path.
2. Click a middle crumb.
   • EXPECTED: It navigates to that ancestor folder.
3. Look at the address bar after the click.
   • EXPECTED: A real path with an archive number and link id — no null or
     undefined segment such as /private/null/194781.

---

Shared record via share preview

Scenario — open a shared record

1. Open a share link that points at a single record (not a folder).
   • EXPECTED: The record opens

---

Error handling

Scenario — deep link to a folder that does not exist

1. Edit a timeline deep-link URL to use a bogus folderLinkId and load it.
   • EXPECTED: An error message is shown and you are redirected to /private. Previously
     this threw a TypeError inside the error handler, because the deep-link target has no
     type to call .includes('root') on.

[codecov]

Codecov Report

❌ Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.12%. Comparing base (8f4a06a) to head (13fb2e7).

Files with missing lines	Patch %	Lines
...c/app/core/resolves/lean-folder-resolve.service.ts	66.66%	4 Missing and 1 partial ⚠️
...omponents/timeline-view/timeline-view.component.ts	75.00%	2 Missing ⚠️
src/app/shared/utilities/folder-error-message.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   53.79%   53.12%   -0.68%     
==========================================
  Files         359      364       +5     
  Lines       12384    12776     +392     
  Branches     2256     2323      +67     
==========================================
+ Hits         6662     6787     +125     
- Misses       5485     5750     +265     
- Partials      237      239       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

Breadcrumb identifier handling can still produce invalid null/undefined path segments and the deep-link resolver currently passes folder_linkId as a string instead of a number, risking incorrect navigation and requests.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR migrates timeline navigation (and lean folder resolving) from the legacy navigateLean v1 endpoint to Stela-backed getWithChildren via a new getWithChildrenByIdentifier helper, while also translating Stela accessRole values into the app’s access.role.* permissions model.

Changes:

• Update timeline folder navigation and lean folder resolver to use getWithChildrenByIdentifier and unify error handling via getFolderErrorMessage.
• Extend Stela folder/record conversion to map breadcrumbs (pathAsArchiveNbr, pathAsFolder_linkId) and translate accessRole.
• Add/expand unit tests for timeline view, timeline breadcrumbs, access-role translation, folder repo behavior, and lean folder resolver.

File summaries

File	Description
src/app/views/components/timeline-view/timeline-view.component.ts	Switch folder navigation to getWithChildrenByIdentifier with toast error handling.
src/app/views/components/timeline-view/timeline-view.component.spec.ts	Add unit tests around onFolderClick success/error behavior.
src/app/views/components/timeline-view/timeline-breadcrumbs/timeline-breadcrumbs.component.spec.ts	Add breadcrumb construction tests from currentFolder path arrays.
src/app/shared/utilities/folder-error-message.ts	Introduce shared helper for deriving a translatable folder-load error key.
src/app/shared/services/api/record.repo.ts	Translate Stela accessRole into access.role.* and preserve optionality.
src/app/shared/services/api/record.repo.spec.ts	Add tests for access-role translation and merging behavior.
src/app/shared/services/api/folder.repo.ts	Map breadcrumb arrays from Stela payload and add getWithChildrenByIdentifier.
src/app/shared/services/api/folder.repo.spec.ts	Add tests for breadcrumb mapping, identifier resolution, and role translation.
src/app/models/access-role.ts	Add Stela archive-membership role types + translation utilities.
src/app/models/access-role.spec.ts	Add tests ensuring translation coverage and compatibility with existing enums.
src/app/core/resolves/lean-folder-resolve.service.ts	Convert resolver to async/await and use getWithChildrenByIdentifier + shared error message helper.
src/app/core/resolves/lean-folder-resolve.service.spec.ts	Add resolver tests for defaults, deep links, share record case, and error redirects.

Review details

Suppressed comments (1)

src/app/core/resolves/lean-folder-resolve.service.ts:35

• folder_linkId on FolderVO is a number, but the deep-link resolver passes the raw route param string through. This can break strict-equality comparisons and can lead to malformed requests when the repo expects numeric link ids; coerce it to a finite number (or leave it undefined so the existing error path can redirect).

		if (route.params.archiveNbr && route.params.folderLinkId) {
			targetFolder = new FolderVO({
				archiveNbr: route.params.archiveNbr,
				folder_linkId: route.params.folderLinkId,
			});

• Files reviewed: 12/12 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[aasandei-vsp]

@slifty I have solved the copilot suggestions, do you think you could have another look, please?

[slifty]

Hooray!

[omnignorant]

UAT passed on dev (branch PER-10677-replace-navigate-lean-timeline, commit 13fb2e7, Chrome only).

Verified: timeline loads with items plotted and the breadcrumb path shown; clicking a folder tile navigates in and appends a crumb; clicking a crumb two folders deep navigates back and the contents change; timeline deep links resolve in a fresh tab. Permissions hold in both directions - as owner, rename/copy/move/delete/share/publish are all enabled; in a Viewer-role share, only download is enabled and the name is not editable. A deep link with a bogus folder id shows "Folder not found" and redirects to /private with no console exception (reproduced twice). A shared record opens from a share preview.

Two non-blocking notes. Timeline navigation does not update the address bar - after clicking into a subfolder the URL still points at the folder the view was opened with, so a copied URL goes to the wrong place. And the PR title cites PER-10679, while the commits reference PER-10677; PER-10679 is the publish dialog delivered in #1135.

No Safari pass.