Per 10423 make archivematica efs compatible - #22
Merged
Merged
Conversation
liam-lloyd
marked this pull request as draft
August 27, 2026 17:57
liam-lloyd
force-pushed
the
per-10423_make_archivematica_efs_compatible
branch
from
August 27, 2026 18:15
783c069 to
e3c107b
Compare
Currently, the greater latency of EFS operations can cause race-condition-driven errors in Archivematica's watch_dirs.py logic, which in the worst case can cause the watch_dirs process to fail silently, leading processing to hang. This commit updates watch_dirs to avoid that. It also makes watch_dirs fail explicitly if it attempts to use inotify mode against an NFS-based filesystem, because this will not work.
liam-lloyd
force-pushed
the
per-10423_make_archivematica_efs_compatible
branch
from
August 27, 2026 18:29
e3c107b to
350b20b
Compare
liam-lloyd
marked this pull request as ready for review
August 27, 2026 18:29
When running against EFS, Archivematica can run into an issue in the NFS client where a move operation fails because as it looks up the directory to be moved, it realizes that another client has moved it from the place where this client last saw it to another place. This triggers an effort to update where that directory lives in the client's internal state, which fails because it needs a lock that the original move operation is holding. This commit updates Archivematica to retry failed move operations once, which will deterministicly fix this particular bug, because mv's error handling reads the directory it failed to move, which successful triggers the client to update where that directory lives in its internal representation.
liam-lloyd
force-pushed
the
per-10423_make_archivematica_efs_compatible
branch
from
August 27, 2026 22:51
350b20b to
a0ce171
Compare
cecilia-donnelly
approved these changes
Aug 31, 2026
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
This makes sense to me! I don't think I can meaningfully test it, though (and I know you have done so).
I will also note that my Python is extremely rusty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.