Fix 1.18 linting - #17
Merged
Merged
Conversation
liam-lloyd
force-pushed
the
fix_1.18_linting
branch
from
February 20, 2026 19:44
fedb0f8 to
fd80103
Compare
Member
Author
|
This is a weird PR and Github isn't presenting it correctly. Here's what's actually going on:
|
Member
|
Just a note that the change to fix the |
cecilia-donnelly
approved these changes
Feb 23, 2026
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
It is weird that GitHub can't figure this out, but I did verify the changes from the command line. It looks like you'll need to rebase on our main to pick up the fix to isInstance you just made, or cherry-pick it over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.