Add porting test for embed.pl visibility - #24638
Open
khwilliamson wants to merge 1 commit into
Open
Conversation
The array '@unresolved_visibility_overrides' in regen/embed.pl is supposed to contain pre-existing symbols that we haven't resolved the final status of yet. When that is done, the symbols in it should be removed and placed depending on their resolution, Newly created symbols should have their final disposition known, so shouldn't go into this array. This test is a quick and dirty check that new symbols aren't getting wrongly added.
Contributor
That first sentence in the commit message ends in a comma. Was there more to come, or should it have been a period? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array '@unresolved_visibility_overrides' in regen/embed.pl is supposed to contain pre-existing symbols that we haven't resolved the final status of yet. When that is done, the symbols in it should be removed and placed depending on their resolution,
Newly created symbols should have their final disposition known, so shouldn't go into this array. This test is a quick and dirty check that new symbols aren't getting wrongly added.