Magic v2 Internal Code Conversions - #24547
Conversation
|
All three commits currently introduce new warnings when building with I still don't have a satisfactory solution to this problem. My personal vote is "lets stop caring about building Perl using g++". |
|
Another one would be argvout_vtbl in doio.c, that's on an IO but it only uses the free and dup callbacks. |
|
It looks reasonable, but I think the g++ build thing needs to be resolved one way or another. |
b1fde0c to
32d5641
Compare
|
I've opened a new issue (#24553) to discuss the |
32d5641 to
173a190
Compare
|
Ahyes; I had missed the one in |
173a190 to
c1bef0a
Compare
c1bef0a to
c705d33
Compare
c705d33 to
1d3f27f
Compare
a3bd9d0 to
7b1e3bd
Compare
3bfab2a to
25ce5aa
Compare
| #define NEEDS_LINES 1 | ||
|
|
||
| static const MGVTBL PerlIOEncode_tag = { 0, 0, 0, 0, 0, 0, 0, 0 }; | ||
| /* An empty hook structure just for the purpose of marking an SV */ |
There was a problem hiding this comment.
:encoding has always struck me as the sort of module that should be dual-life, but clearly absolutely no one wants that responsibility so probably this is fine.
25ce5aa to
a9b1f24
Compare
a9b1f24 to
a194182
Compare
|
Annoyingly, github appears to believe this PR wants to add 6 commits, even though the first 2 of those have already been merged; this would only do the other 4. Rather than risk an upset here I will merge it on commandline. |
a194182 to
7c9c085
Compare
7c9c085 to
ab4447b
Compare
|
github is confused about what I did here. This was merged with a local |
(This is a dependent PR that requires first that #24163 be merged)
The
threefour new commits here are each individual conversions ofstaticinternal magic types to use magic v2. None of them are strictly "required", but we felt it useful to have some code sitting around that uses magic-v2, as a demonstration that it works. These ones were picked because they're all static and don't have associatedPERL_MAGIC_*constants anyway, so there's no way that external code / CPAN / DarkPAN would be aware of them in any way that this could break.