feat: Leading and trailing edge debounce for the file watch#9
Open
Mike-Dax wants to merge 1 commit into
Open
Conversation
feat: Hash the files and don't re-run the compilation if they're the same. feat: Ignore initial file watch events. feat: Different hash feat: Removed timer
Owner
|
Hmmm. Will need to test this one out a bit. There was a few situations I've been trying to address with the delay, and it was the quickest hack I could think of:
Might take a bit longer to get back to you on this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the 100ms wait before starting compilation of changed files and instead introduces a leading+trailing edge debounce + an md5 hash.
The previous behavior was to wait until the 100ms after the last time the user saved a file, then it would compile.
Now it will immediately compile upon first save, and if the file is saved again it will debounce in a similar manner to previously. It will also hash the file and check if it has changed since the last compile. The debounce has been increased to 300ms.