Skip to content

Add user ldaps - #966

Closed
overgrowncarrot1 wants to merge 4 commits into
Pennyw0rth:mainfrom
overgrowncarrot1:add_user-ldaps
Closed

overgrowncarrot1 wants to merge 4 commits into
Pennyw0rth:mainfrom
overgrowncarrot1:add_user-ldaps

Conversation

@overgrowncarrot1

Copy link
Copy Markdown

Description

Module to add a new user to ldap, defaults to domain admins group, however user can pick group. Also defaults to username foobar with password P@ssw0rd!, user can pick username and password. User can also delete newly created user.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)

Setup guide for the review

None, tested on GOAD, just an AD machine
In particular:

  • Added Feature/Enhancement: Please specify what setup is needed in order to test the changes. None

Screenshots (if appropriate):

image

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • New and existing e2e tests pass locally with my changes
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

overgrowncarrot1 and others added 4 commits October 21, 2025 18:48
Signed-off-by: Ryan Yager <78485709+overgrowncarrot1@users.noreply.github.com>
Removed 'smb' from supported protocols for add_user module.

Signed-off-by: Ryan Yager <78485709+overgrowncarrot1@users.noreply.github.com>
Signed-off-by: Ryan Yager <78485709+overgrowncarrot1@users.noreply.github.com>
@NeffIsBack

Copy link
Copy Markdown
Member

Thanks for the PR!

We should probably wait for #843 to be merged so we have a standard version of creating ldap3 connection objects.
Also the PR is partially duplicate to #688. Not sure yet what the best way is to handle that.

@NeffIsBack

Copy link
Copy Markdown
Member

Closing as this is duplicate to #688

@NeffIsBack NeffIsBack closed this Mar 17, 2026
@NeffIsBack NeffIsBack added the duplicate This issue or pull request already exists label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants