Skip to content

Add share type to shares output - #1531

Open
NeffIsBack wants to merge 6 commits into
mainfrom
neff-add-print-type
Open

NeffIsBack wants to merge 6 commits into
mainfrom
neff-add-print-type

Conversation

@NeffIsBack

Copy link
Copy Markdown
Member

Description

Small QOL change: Adds the share "type" which can help identifying printers and supposedly clusters as well.

AI Assistance

Done with the help of ChatGPT Astra on max

Type of change

Insert an "x" inside the brackets for relevant items

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

Install a printer: https://support.microsoft.com/en-gb/windows/hardware/printer/share-a-printer-as-a-network-printer
Run --shares against a host with a printer.

Screenshots (if appropriate):

image Let me know if you find the output now too crowded and if we should spread it more.

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

  • I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
  • I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
  • If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
  • I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
  • I have performed a self-review of my own code (not an AI review)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

@NeffIsBack NeffIsBack added the enhancement New feature or request label Nov 15, 2026
@NeffIsBack NeffIsBack changed the title Neff add print type Add share type to shares output Nov 15, 2026
Comment thread nxc/protocols/smb.py Resolved
Comment thread nxc/protocols/smb.py Resolved
Comment thread nxc/protocols/smb/database.py Resolved
Comment thread nxc/nxcdb.py Resolved
@NeffIsBack
NeffIsBack requested a review from azoxlpf November 18, 2026 16:21

@azoxlpf azoxlpf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants