Repository navigation
Feature/ldap password never expires - #1529
Merged
NeffIsBack merged 3 commits intoNov 17, 2026
Merged
Conversation
CSpanias
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
November 14, 2026 16:57
NeffIsBack
requested changes
Nov 16, 2026
NeffIsBack
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
Please just filter out disabled accounts via the search filter and also display the pw last change timestamp (see --users for example)
Contributor
Author
|
Hi @NeffIsBack, Thanks for reviewing the PR; changes implemented as requested:
Let me know if anything else is needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
New LDAP option
--password-never-expires. As the name suggests, it searches for accounts with theDONT_EXPIRE_PASSWORDUserAccountControl flag.AI Assistance
Copilot SDK in VS Code and that it assisted with the implementation and e2e command. The model name is Copilot Fusion.
Type of change
Setup guide for the review
DONT_EXPIRE_PASSWORD) enabled.No GPO change is needed; you can enable it in the account’s Account properties in AD Users and Computers, as shown below:
The command to run, for example:
Expected result: the flagged account(s) are listed with their enabled/disabled status.
Screenshots
Tested against my lab DC filled with BadBlood data:
Checklist:
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)P.S. Sorry for the line ending changes before!