Repository navigation
Feature/ntlmsign - #1525
Open
SoftAndoWetto wants to merge 10 commits into
Open
Feature/ntlmsign#1525SoftAndoWetto wants to merge 10 commits into
SoftAndoWetto wants to merge 10 commits into
Conversation
This module checks if a target enforces NTLM signing by performing two NTLM authentications, one with signing and one without, and logs the results. Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
SoftAndoWetto
marked this pull request as ready for review
November 13, 2026 11:06
SoftAndoWetto
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
November 13, 2026 11:06
Member
|
Thanks for the PR! Can't we just do a manual NTLM handshake on both SMB and LDAP instead of missusing SMBs "normal" login function? Also why don't we support SMBv1? |
Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
Contributor
Author
|
Hello Neff, Youre right about the SMB implementation, after looking into it more I understand it is fragile and would make more sense to do the full handshake lol, apologies. As for the SMBv1 not being supported, SMBv1 doesn't use NTLMSSP, meaning the client cant tell the server that it supports NTLM singing, so I just skipped it if it uses it |
NeffIsBack
requested changes
Nov 16, 2026
Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
SoftAndoWetto
commented
Nov 17, 2026
SoftAndoWetto
left a comment
Contributor
Author
There was a problem hiding this comment.
All of the comments have now been addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Created a module for checking whether a server has NTLM Signing enforced.
LDAP:
2 NTLM sicily binds are performed
SMB:
Results:
T/F - NTLM Signing is enforced, must succeed before the second is sent
T/T - NTLM Signing is not enforced
F/. - Unknown
Skipped for Kerberos, Schannel or when NTLM is disabled
AI Assistance
Model: Claude Sonnet 5.5
Note that if you have used AI, you:
Type of change
Insert an "x" inside the brackets for relevant items
Setup guide for the review
Tested against Windows Server 2019 (build 17763) DC, domain
enclave.local, with a standard domain user.ServerRequireNtlmSign(REG_DWORD)Screenshots (if appropriate):
The module with

ServerRequireNtlmSignboth enabled and disabled (SMB)The module with

ServerRequireNtlmSignboth enabled and disabled (LDAP)Kerberos exception

Schannel exception

Null Auth exception

Checklist:
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)