Repository navigation
Flag Unconstrained delegation in LDAP processing - #1513
Conversation
Record Unconstrained delegation before overwriting delegation and rightsTo. Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
|
Thank you for PR. I tested it against HTB (cant use my local lab right now); I think this fixes the Unconstrained + Constrained case (your case) But the elif in the first block still hides Protocol Transition. If an account has I believe this way of fixing it is more sound. Could you also test it this way in your own lab, just to be sure? Once you have checked it as well, Then need to get @NeffIsBack opinion about the situation. |
|
Works on my side |
|
agreed with @termanix fix |
Please apply it then :D |
Refactor delegation handling logic for clarity and correctness. Signed-off-by: SoftAndoWetto <188264635+SoftAndoWetto@users.noreply.github.com>
Feedback for the review: Having an explanation where to configure this helps. In this case I know where the UI is, but people (including me) might not know especially with more complicated stuff like configuring Kerberos magic. |
NeffIsBack
left a comment
There was a problem hiding this comment.
LGTM although I still wonder how this could even be configured (see #1512 (comment)). Also made a bunch of improvements to the overall code while I was at it and deprecated --trusted-for-delegation as discussed on discord. @mpgn could you review my changes?
Record Unconstrained delegation before overwriting delegation and rightsTo.
Description
Fix to the issue I raised #1512 where if an account has both UF_TRUSTED_FOR_DELEGATION and msDS-AllowedToDelegateTo set then "Unconstrained" gets overwritten by "Constrained" rather than both being listed
AI Assistance
Claude Sonnet 5
Type of change
Insert an "x" inside the brackets for relevant items
Setup guide for the review
Have an account with both UF_TRUSTED_FOR_DELEGATION and msDS-AllowedToDelegateTo, then run the nxc flag --find-delegation
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run ruff check ., use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)